tracefs: Annotate tracefs_ops with __ro_after_init
PATCH 1/1 tracefs: Annotate tracefs_ops with __ro_after_init
tracefs_ops is initialized inside tracefs_create_instance_dir and not modified after. tracefs_create_instance_dir allows for initialization only once, and is called from create_trace_instances(marked __init), which is called from tracer_init_tracefs(marked __init).
--- fs/tracefs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/tracefs/inode.c +1 -1
@@ -53,7 +53,7 @@ static const struct file_operations tracefs_file_operations = {static struct tracefs_dir_ops {int (*mkdir)(const char *name);int (*rmdir)(const char *name); -} tracefs_ops; +} tracefs_ops__ro_after_init ;static char *get_dname (struct dentry *dentry) {
Signature · 1 line
2.18.0.233.g985f88cf7e-goog
Adding Steven (maintainer) and Al (fs) to CC...
Quoted 7 lines · Zubin Mithra
tracefs_opsis initialized insidetracefs_create_instance_dirand not modified after.tracefs_create_instance_dirallows for initialization only once, and is called fromcreate_trace_instances(marked __init), which is called fromtracer_init_tracefs(marked __init).Signed-off-by Zubin Mithra <[email protected]>Reviewed-by Kees Cook <[email protected]>
Who's tree should this go through?
Thanks!
-Kees
Quoted 20 lines
--- fs/tracefs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/tracefs/inode.c +1
-2@@ -53,7 +53,7 @@ static const struct file_operations tracefs_file_operations = {static struct tracefs_dir_ops {int (*mkdir)(const char *name);int (*rmdir)(const char *name); -} tracefs_ops; +} tracefs_ops__ro_after_init ;static char *get_dname (struct dentry *dentry) { --2.18.0.233.g985f88cf7e-goog
Signature · 2 lines
Kees Cook Pixel Security
Steven Rostedt
maintainerQuoted 1 line · On Tue, 24 Jul 2018 15:07:18 -0700 Kees Cook <[email protected]> wrote:
Adding Steven (maintainer) and Al (fs) to CC...
Thanks, first I've seen of this.
Quoted 6 lines · Zubin Mithra
Quoted 4 lines
tracefs_opsis initialized insidetracefs_create_instance_dirand not modified after.tracefs_create_instance_dirallows for initialization only once, and is called fromcreate_trace_instances(marked __init), which is called fromtracer_init_tracefs(marked __init).
Then, especially with this change, we should mark tracefs_create_instance_dir() as init, as it would fail any other time.
Quoted 5 lines
Quoted 3 lines
Signed-off-by Zubin Mithra <[email protected]>Reviewed-by Kees Cook <[email protected]>Who's tree should this go through?
I can take it or someone else can, and I'll ack it if need be.
-- Steve
Quoted 28 lines
Thanks!
-Kees
Quoted 20 lines
--- fs/tracefs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/tracefs/inode.c +1
-2@@ -53,7 +53,7 @@ static const struct file_operations tracefs_file_operations = {static struct tracefs_dir_ops {int (*mkdir)(const char *name);int (*rmdir)(const char *name); -} tracefs_ops; +} tracefs_ops__ro_after_init ;static char *get_dname (struct dentry *dentry) { --2.18.0.233.g985f88cf7e-goog