drm/amd: Add missing fields in atom_integrated_system_info_v1_11
Subsystems (2)
PATCH 1/1 drm/amd: Add missing fields in atom_integrated_system_info_v1_11
This structure needs to align with structure in atomfirmware table. Update it.
--- drivers/gpu/drm/amd/include/atomfirmware.h | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/include/atomfirmware.h +11 -4
@@ -1074,7 +1074,7 @@ struct atom_integrated_system_info_v1_11uint16_t dpphy_override;// bit vector, enum of atom_sysinfo_dpphy_override_def uint16_t lvds_misc;// enum of atom_sys_info_lvds_misc_def uint16_t backlight_pwm_hz;// pwm frequency in hz -uint8_t memorytype;// enum of atom_sys_mem_type +uint8_t memorytype;// enum of atom_dmi_t17_mem_type_def, APU memory type indication. uint8_t umachannelnumber;// number of memory channels uint8_t pwr_on_digon_to_de;/* all pwr sequence numbers below are in uint of 4ms */ uint8_t pwr_on_de_to_vary_bl;
@@ -1084,18 +1084,25 @@ struct atom_integrated_system_info_v1_11uint8_t pwr_on_vary_bl_to_blon;uint8_t pwr_down_bloff_to_vary_bloff;uint8_t min_allowed_bl_level; +uint8_t htc_hyst_limit; +uint8_t htc_tmp_limit; +uint8_t reserved1; +uint8_t reserved2;struct atom_external_display_connection_info extdispconninfo;struct atom_14nm_dpphy_dvihdmi_tuningset dvi_tuningset;struct atom_14nm_dpphy_dvihdmi_tuningset hdmi_tuningset;struct atom_14nm_dpphy_dvihdmi_tuningset hdmi6g_tuningset; -struct atom_14nm_dpphy_dp_tuningset dp_tuningset; -struct atom_14nm_dpphy_dp_tuningset dp_hbr3_tuningset; +struct atom_14nm_dpphy_dp_tuningset dp_tuningset;// rbr 1.62G dp tuning set +struct atom_14nm_dpphy_dp_tuningset dp_hbr3_tuningset;// HBR3 dp tuning set struct atom_camera_data camera_info;struct atom_hdmi_retimer_redriver_set dp0_retimer_set;//for DP0 struct atom_hdmi_retimer_redriver_set dp1_retimer_set;//for DP1 struct atom_hdmi_retimer_redriver_set dp2_retimer_set;//for DP2 struct atom_hdmi_retimer_redriver_set dp3_retimer_set;//for DP3 -uint32_t reserved[108 ]; +struct atom_14nm_dpphy_dp_tuningset dp_hbr_tuningset;//hbr 2.7G dp tuning set +struct atom_14nm_dpphy_dp_tuningset dp_hbr2_tuningset;//hbr2 5.4G dp turnig set +struct atom_14nm_dpphy_dp_tuningset edp_tuningset;//edp tuning set +uint32_t reserved[66 ]; };
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 20180725134547.14596-1-harry.wentland-5C7GfCeVMHo@public.gmane.org
Alex Deucher
Acked-byQuoted 4 lines · Harry Wentland
This structure needs to align with structure in atomfirmware table. Update it.
Signed-off-by Harry Wentland <[email protected]>
Quoted 49 lines
--- drivers/gpu/drm/amd/include/atomfirmware.h | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)drivers/gpu/drm/amd/include/atomfirmware.h +11
-5@@ -1074,7 +1074,7 @@ struct atom_integrated_system_info_v1_11uint16_t dpphy_override;// bit vector, enum of atom_sysinfo_dpphy_override_def uint16_t lvds_misc;// enum of atom_sys_info_lvds_misc_def uint16_t backlight_pwm_hz;// pwm frequency in hz -uint8_t memorytype;// enum of atom_sys_mem_type +uint8_t memorytype;// enum of atom_dmi_t17_mem_type_def, APU memory type indication. uint8_t umachannelnumber;// number of memory channels uint8_t pwr_on_digon_to_de;/* all pwr sequence numbers below are in uint of 4ms */ uint8_t pwr_on_de_to_vary_bl;@@ -1084,18 +1084,25 @@ struct atom_integrated_system_info_v1_11uint8_t pwr_on_vary_bl_to_blon;uint8_t pwr_down_bloff_to_vary_bloff;uint8_t min_allowed_bl_level; +uint8_t htc_hyst_limit; +uint8_t htc_tmp_limit; +uint8_t reserved1; +uint8_t reserved2;struct atom_external_display_connection_info extdispconninfo;struct atom_14nm_dpphy_dvihdmi_tuningset dvi_tuningset;struct atom_14nm_dpphy_dvihdmi_tuningset hdmi_tuningset;struct atom_14nm_dpphy_dvihdmi_tuningset hdmi6g_tuningset; -struct atom_14nm_dpphy_dp_tuningset dp_tuningset; -struct atom_14nm_dpphy_dp_tuningset dp_hbr3_tuningset; +struct atom_14nm_dpphy_dp_tuningset dp_tuningset;// rbr 1.62G dp tuning set +struct atom_14nm_dpphy_dp_tuningset dp_hbr3_tuningset;// HBR3 dp tuning set struct atom_camera_data camera_info;struct atom_hdmi_retimer_redriver_set dp0_retimer_set;//for DP0 struct atom_hdmi_retimer_redriver_set dp1_retimer_set;//for DP1 struct atom_hdmi_retimer_redriver_set dp2_retimer_set;//for DP2 struct atom_hdmi_retimer_redriver_set dp3_retimer_set;//for DP3 -uint32_t reserved[108 ]; +struct atom_14nm_dpphy_dp_tuningset dp_hbr_tuningset;//hbr 2.7G dp tuning set +struct atom_14nm_dpphy_dp_tuningset dp_hbr2_tuningset;//hbr2 5.4G dp turnig set +struct atom_14nm_dpphy_dp_tuningset edp_tuningset;//edp tuning set +uint32_t reserved[66 ]; }; --2.17.1
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): CADnq5_Nghjox1msLh0wofCTwm2B8Hbt=z5YvPbTo6h=vbU4k9g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Quoted 8 lines · Alex Deucher
Quoted 4 lines · Harry Wentland
This structure needs to align with structure in atomfirmware table. Update it.
Signed-off-by Harry Wentland <[email protected]>Acked-by Alex Deucher <[email protected]>
Looks like patchwork messed up the author and I didn't catch it when pushing this. Will revert and push the correct version.
Harry
Quoted 46 lines
Quoted 46 lines
--- drivers/gpu/drm/amd/include/atomfirmware.h | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)drivers/gpu/drm/amd/include/atomfirmware.h +11
-4@@ -1074,7 +1074,7 @@ struct atom_integrated_system_info_v1_11uint16_t dpphy_override;// bit vector, enum of atom_sysinfo_dpphy_override_def uint16_t lvds_misc;// enum of atom_sys_info_lvds_misc_def uint16_t backlight_pwm_hz;// pwm frequency in hz -uint8_t memorytype;// enum of atom_sys_mem_type +uint8_t memorytype;// enum of atom_dmi_t17_mem_type_def, APU memory type indication. uint8_t umachannelnumber;// number of memory channels uint8_t pwr_on_digon_to_de;/* all pwr sequence numbers below are in uint of 4ms */ uint8_t pwr_on_de_to_vary_bl;@@ -1084,18 +1084,25 @@ struct atom_integrated_system_info_v1_11uint8_t pwr_on_vary_bl_to_blon;uint8_t pwr_down_bloff_to_vary_bloff;uint8_t min_allowed_bl_level; +uint8_t htc_hyst_limit; +uint8_t htc_tmp_limit; +uint8_t reserved1; +uint8_t reserved2;struct atom_external_display_connection_info extdispconninfo;struct atom_14nm_dpphy_dvihdmi_tuningset dvi_tuningset;struct atom_14nm_dpphy_dvihdmi_tuningset hdmi_tuningset;struct atom_14nm_dpphy_dvihdmi_tuningset hdmi6g_tuningset; -struct atom_14nm_dpphy_dp_tuningset dp_tuningset; -struct atom_14nm_dpphy_dp_tuningset dp_hbr3_tuningset; +struct atom_14nm_dpphy_dp_tuningset dp_tuningset;// rbr 1.62G dp tuning set +struct atom_14nm_dpphy_dp_tuningset dp_hbr3_tuningset;// HBR3 dp tuning set struct atom_camera_data camera_info;struct atom_hdmi_retimer_redriver_set dp0_retimer_set;//for DP0 struct atom_hdmi_retimer_redriver_set dp1_retimer_set;//for DP1 struct atom_hdmi_retimer_redriver_set dp2_retimer_set;//for DP2 struct atom_hdmi_retimer_redriver_set dp3_retimer_set;//for DP3 -uint32_t reserved[108 ]; +struct atom_14nm_dpphy_dp_tuningset dp_hbr_tuningset;//hbr 2.7G dp tuning set +struct atom_14nm_dpphy_dp_tuningset dp_hbr2_tuningset;//hbr2 5.4G dp turnig set +struct atom_14nm_dpphy_dp_tuningset edp_tuningset;//edp tuning set +uint32_t reserved[66 ]; };
Quoted 7 lines
Quoted 7 lines
--
2.17.1_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Laktyushkin, Dmytro
Reviewed-by Dmytro LaktyushkinLooks good
-----Original Message-----
From: Harry Wentland [mailto:[email protected]]
Sent: Wednesday, July 25, 2018 09:46
To: [email protected]; Laktyushkin, Dmytro <[email protected]>; Cheng, Tony <[email protected]>
Cc: Wentland, Harry <[email protected]>
Subject: [PATCH] drm/amd: Add missing fields in atom_integrated_system_info_v1_11
This structure needs to align with structure in atomfirmware table. Update it.
--- drivers/gpu/drm/amd/include/atomfirmware.h | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/include/atomfirmware.h +11 -4
@@ -1074,7 +1074,7 @@ struct atom_integrated_system_info_v1_11uint16_t dpphy_override;// bit vector, enum of atom_sysinfo_dpphy_override_def uint16_t lvds_misc;// enum of atom_sys_info_lvds_misc_def uint16_t backlight_pwm_hz;// pwm frequency in hz -uint8_t memorytype;// enum of atom_sys_mem_type +uint8_t memorytype;// enum of atom_dmi_t17_mem_type_def, APU memory type indication. uint8_t umachannelnumber;// number of memory channels uint8_t pwr_on_digon_to_de;/* all pwr sequence numbers below are in uint of 4ms */ uint8_t pwr_on_de_to_vary_bl;
@@ -1084,18 +1084,25 @@ struct atom_integrated_system_info_v1_11uint8_t pwr_on_vary_bl_to_blon;uint8_t pwr_down_bloff_to_vary_bloff;uint8_t min_allowed_bl_level; +uint8_t htc_hyst_limit; +uint8_t htc_tmp_limit; +uint8_t reserved1; +uint8_t reserved2;struct atom_external_display_connection_info extdispconninfo;struct atom_14nm_dpphy_dvihdmi_tuningset dvi_tuningset;struct atom_14nm_dpphy_dvihdmi_tuningset hdmi_tuningset;struct atom_14nm_dpphy_dvihdmi_tuningset hdmi6g_tuningset; -struct atom_14nm_dpphy_dp_tuningset dp_tuningset; -struct atom_14nm_dpphy_dp_tuningset dp_hbr3_tuningset; +struct atom_14nm_dpphy_dp_tuningset dp_tuningset;// rbr 1.62G dp tuning set +struct atom_14nm_dpphy_dp_tuningset dp_hbr3_tuningset;// HBR3 dp tuning set struct atom_camera_data camera_info;struct atom_hdmi_retimer_redriver_set dp0_retimer_set;//for DP0 struct atom_hdmi_retimer_redriver_set dp1_retimer_set;//for DP1 struct atom_hdmi_retimer_redriver_set dp2_retimer_set;//for DP2 struct atom_hdmi_retimer_redriver_set dp3_retimer_set;//for DP3 -uint32_t reserved[108 ]; +struct atom_14nm_dpphy_dp_tuningset dp_hbr_tuningset;//hbr 2.7G dp tuning set +struct atom_14nm_dpphy_dp_tuningset dp_hbr2_tuningset;//hbr2 5.4G dp turnig set +struct atom_14nm_dpphy_dp_tuningset edp_tuningset;//edp tuning set +uint32_t reserved[66 ]; };
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx