Skip to contentSkip to conversation

glamor: Set AMDGPU_CREATE_PIXMAP_DRI2 for DRI3 pixmaps

PATCH In review Michel Dänzer 2 participants 2 messages Jul 25, 2018 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 glamor: Set AMDGPU_CREATE_PIXMAP_DRI2 for DRI3 pixmaps

From: Michel Dänzer <[email protected]>

Not doing this resulted in falling back to software for DRI3 client presentation operations with ShadowPrimary.

---
 src/amdgpu_dri3.c | 1 +
 1 file changed, 1 insertion(+)
src/amdgpu_dri3.c +1 -0
index 87e3d85c1..84a03dc36 100644
@@ -168,6 +168,7 @@ static PixmapPtr amdgpu_dri3_pixmap_from_fd(ScreenPtr screen,
 
 			if (priv) {
 				amdgpu_set_pixmap_private(pixmap, priv);
+				pixmap->usage_hint |= AMDGPU_CREATE_PIXMAP_DRI2;
 				return pixmap;
 			}
 
Signature · 6 lines
2.18.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20180725163833.21476-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org

Reviewed-by
#2 lore raw
Quoted 6 lines · Michel Dänzer

From: Michel Dänzer <[email protected]>

Not doing this resulted in falling back to software for DRI3 client presentation operations with ShadowPrimary.

Quoted 19 lines
---
 src/amdgpu_dri3.c | 1 +
 1 file changed, 1 insertion(+)
src/amdgpu_dri3.c +1 -1
index 87e3d85c1..84a03dc36 100644
@@ -168,6 +168,7 @@ static PixmapPtr amdgpu_dri3_pixmap_from_fd(ScreenPtr screen,
 
                        if (priv) {
                                amdgpu_set_pixmap_private(pixmap, priv);
+                               pixmap->usage_hint |= AMDGPU_CREATE_PIXMAP_DRI2;
                                return pixmap;
                        }
 
--

2.18.0

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx