drm/i915: WaPsrDisableDpfcClkGating for glk and cnl
Subsystems (2)
Rodrigo Vivi
maintainerPATCH 1/1 drm/i915: WaPsrDisableDpfcClkGating for glk and cnl
"Host modification in FBC does not trigger PSR to exit sleep state"
Since we are relying more on HW tracking lately it is better to protect this gen10 displays.
--- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 8 ++++++++ 2 files changed, 9 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +1 -0
@@ -4027,6 +4027,7 @@ enum {#define PWM1_GATING_DIS (1 << 13)#define GEN9_CLKGATE_DIS_4 _MMIO(0x4653C) +#define DPFC_GATING_DIS (1 << 31)#define BXT_GMBUS_GATING_DIS (1 << 14)#define _CLKGATE_DIS_PSL_A 0x46520
drivers/gpu/drm/i915/intel_pm.c +8 -0
@@ -137,6 +137,9 @@ static void glk_init_clock_gating(struct drm_i915_private *dev_priv)I915_WRITE (CHICKEN_MISC_2 , val); } +/* WaPsrDisableDpfcClkGating:glk */ +I915_WRITE (GEN9_CLKGATE_DIS_4 ,I915_READ (GEN9_CLKGATE_DIS_4 ) | +DPFC_GATING_DIS ); }static void i915_pineview_get_mem_freq (struct drm_i915_private *dev_priv)
@@ -8715,6 +8718,11 @@ static void cnl_init_clock_gating(struct drm_i915_private *dev_priv) val =I915_READ (UNSLICE_UNIT_LEVEL_CLKGATE ); val |=VFUNIT_CLKGATE_DIS ;I915_WRITE (UNSLICE_UNIT_LEVEL_CLKGATE , val); + +/* WaPsrDisableDpfcClkGating:cnl (pre-prod) */ +if (IS_CNL_REVID (dev_priv,CNL_REVID_A0 ,CNL_REVID_B0 )) +I915_WRITE (GEN9_CLKGATE_DIS_4 ,I915_READ (GEN9_CLKGATE_DIS_4 ) | +DPFC_GATING_DIS ); }static void cfl_init_clock_gating (struct drm_i915_private *dev_priv)
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: WaPsrDisableDpfcClkGating for glk and cnl
== Series Details ==
== Series Details ==
Series: drm/i915: WaPsrDisableDpfcClkGating for glk and cnl
URL : https://patchwork.freedesktop.org/series/47310/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4554 -> Patchwork_9787 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/47310/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_9787 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_workarounds:
{fi-cfl-8109u}: PASS -> DMESG-FAIL (fdo#107292)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-bxt-dsi: PASS -> INCOMPLETE (fdo#103927)
==== Possible fixes ====
igt@kms_chamelium@dp-edid-read:
fi-kbl-7500u: FAIL (fdo#103841) -> PASS
igt@kms_flip@basic-flip-vs-modeset:
fi-skl-6700hq: DMESG-WARN (fdo#105998) -> PASS {name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
== Participating hosts (50 -> 43) ==
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-u fi-byt-clapper
== Build changes ==
* Linux: CI_DRM_4554 -> Patchwork_9787
CI_DRM_4554: 5ce2e0fe88bd5a3615abb7289ab98d487201c450 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4576: bcb37a9b20eeec97f15fac2222408cc2e0b77631 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9787: da2dfd178e6fb7d74e4e0ddcc10327999e6c7e1b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
da2dfd178e6f drm/i915: WaPsrDisableDpfcClkGating for glk and cnl
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9787/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915: WaPsrDisableDpfcClkGating for glk and cnl
In reply to Rodrigo Vivi== Series Details ==
== Series Details ==
Series: drm/i915: WaPsrDisableDpfcClkGating for glk and cnl
URL : https://patchwork.freedesktop.org/series/47310/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4554_full -> Patchwork_9787_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9787_full need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_9787_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9787_full:
=== IGT changes ===
==== Warnings ====
igt@gem_mocs_settings@mocs-rc6-blt:
shard-kbl: PASS -> SKIP +1
igt@gem_mocs_settings@mocs-rc6-vebox:
shard-kbl: SKIP -> PASS +1== Known issues ==
Here are the changes found in Patchwork_9787_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_suspend@shrink:
shard-apl: PASS -> INCOMPLETE (fdo#103927, fdo#106886)
igt@kms_flip@dpms-vs-vblank-race-interruptible:
shard-glk: PASS -> FAIL (fdo#103060)
igt@kms_flip@plain-flip-fb-recreate-interruptible:
shard-glk: PASS -> FAIL (fdo#100368) +1
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
shard-apl: PASS -> FAIL (fdo#103375)
shard-glk: PASS -> FAIL (fdo#103375)
==== Possible fixes ====
igt@drv_suspend@shrink:
shard-snb: INCOMPLETE (fdo#105411, fdo#106886) -> PASS
igt@gem_eio@in-flight-suspend:
shard-snb: DMESG-WARN (fdo#102365) -> PASS
igt@kms_flip@2x-flip-vs-expired-vblank:
shard-glk: FAIL (fdo#105363) -> PASS
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-glk: FAIL (fdo#105189) -> PASS
igt@kms_flip@plain-flip-ts-check-interruptible:
shard-glk: FAIL (fdo#100368) -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#105189 https://bugs.freedesktop.org/show_bug.cgi?id=105189
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4554 -> Patchwork_9787
CI_DRM_4554: 5ce2e0fe88bd5a3615abb7289ab98d487201c450 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4576: bcb37a9b20eeec97f15fac2222408cc2e0b77631 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9787: da2dfd178e6fb7d74e4e0ddcc10327999e6c7e1b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9787/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx