Skip to contentSkip to conversation

net/virtio-user: fix the param string

PATCH In review Tiwei Bie 2 participants 3 messages Jul 30, 2018 – Aug 1, 2018 Network drivers

lore
Share & tools
lore

Tiwei Bie

author
#0 lore raw

PATCH 1/1 net/virtio-user: fix the param string

Add the missing param "server" to param string.
Also add the missing spaces after params.

Fixes bd8f50a45d0f ("net/virtio-user: support server mode")
---
 drivers/net/virtio/virtio_user_ethdev.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/virtio/virtio_user_ethdev.c +3 -2
index 5ee59d5e5..525d16cab 100644
@@ -681,6 +681,7 @@ RTE_PMD_REGISTER_PARAM_STRING(net_virtio_user,
 	"cq=<int> "
 	"queue_size=<int> "
 	"queues=<int> "
-	"iface=<string>"
-	"mrg_rxbuf=<0|1>"
+	"iface=<string> "
+	"server=<0|1> "
+	"mrg_rxbuf=<0|1> "
 	"in_order=<0|1>");
Signature · 1 line
2.18.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 17 lines · Tiwei Bie

Add the missing param "server" to param string.
Also add the missing spaces after params.

Fixes bd8f50a45d0f ("net/virtio-user: support server mode")
---
  drivers/net/virtio/virtio_user_ethdev.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/virtio/virtio_user_ethdev.c +0 -0
index 5ee59d5e5..525d16cab 100644

drivers/net/virtio/virtio_user_ethdev.c RTE_PMD_REGISTER_PARAM_STRING(net_virtio_user, · line 687

Quoted 9 lines
drivers/net/virtio/virtio_user_ethdev.c +3 -2
@@ -681,6 +681,7 @@ RTE_PMD_REGISTER_PARAM_STRING(net_virtio_user,
  	"cq=<int> "
  	"queue_size=<int> "
  	"queues=<int> "
-	"iface=<string>"
-	"mrg_rxbuf=<0|1>"
+	"iface=<string> "
+	"server=<0|1> "
+	"mrg_rxbuf=<0|1> "
  	"in_order=<0|1>");

Thanks!
Maxime

author Applied
#2 lore raw
Quoted 21 lines · Maxime Coquelin
Quoted 20 lines · Tiwei Bie

Add the missing param "server" to param string.
Also add the missing spaces after params.

Fixes bd8f50a45d0f ("net/virtio-user: support server mode")
---
  drivers/net/virtio/virtio_user_ethdev.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/virtio/virtio_user_ethdev.c +0 -1
index 5ee59d5e5..525d16cab 100644
@@ -681,6 +681,7 @@ RTE_PMD_REGISTER_PARAM_STRING(net_virtio_user,
  	"cq=<int> "
  	"queue_size=<int> "
  	"queues=<int> "
-	"iface=<string>"
Quoted 8 lines

drivers/net/virtio/virtio_user_ethdev.c RTE_PMD_REGISTER_PARAM_STRING(net_virtio_user, · line 687

Quoted 6 lines
drivers/net/virtio/virtio_user_ethdev.c +3 -1
-	"mrg_rxbuf=<0|1>"
+	"iface=<string> "
+	"server=<0|1> "
+	"mrg_rxbuf=<0|1> "
  	"in_order=<0|1>");

Applied to dpdk-next-virtio/master, thanks.