drm/radeon: Replace ttm_bo_reference with ttm_bo_get
Subsystems (2)
PATCH 1/2 drm/radeon: Replace ttm_bo_reference with ttm_bo_get
The function ttm_bo_get acquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put.
--- drivers/gpu/drm/radeon/radeon_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/radeon/radeon_object.c +1 -1
@@ -307,7 +307,7 @@ struct radeon_bo *radeon_bo_ref(struct radeon_bo *bo)if (bo ==NULL )return NULL ; -ttm_bo_reference (&bo->tbo); +ttm_bo_get (&bo->tbo);return bo; }
Signature · 6 lines
2.18.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 2/2 drm/radeon: Replace ttm_bo_unref with ttm_bo_put
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put.
A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. This is not necessary in most cases and sometimes even worked around by the calling code. A call to ttm_bo_put only releases the reference without clearing the pointer.
The current behaviour of cleaning the pointer is kept in the calling code, but should be removed if not required in a later patch.
--- drivers/gpu/drm/radeon/radeon_object.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/radeon/radeon_object.c +2 -3
@@ -320,9 +320,8 @@ void radeon_bo_unref(struct radeon_bo **bo)return ; rdev = (*bo)->rdev; tbo = &((*bo)->tbo); -ttm_bo_unref (&tbo); -if (tbo ==NULL ) - *bo =NULL ; +ttm_bo_put (tbo); + *bo =NULL ; } int radeon_bo_pin_restricted(struct radeon_bo *bo, u32 domain, u64 max_offset,
Signature · 6 lines
2.18.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx