drm/amdgpu: Clean-up TTM BO ref-counting interface
Subsystems (2)
cover drm/amdgpu: Clean-up TTM BO ref-counting interface
This patchset replaces ttm_bo_{reference/unref} with ttm_bo_{get,put}, which follow Linux' conventions for ref-counting functions.
v2:
* use prefix drm/amdgpu
Thomas Zimmermann (2):
drm/amdgpu: Replace ttm_bo_reference with ttm_bo_get drm/amdgpu: Replace ttm_bo_unref with ttm_bo_put
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
--
2.18.0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 1/2 drm/amdgpu: Replace ttm_bo_reference with ttm_bo_get
The function ttm_bo_get acquires a reference on a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put.
v2:
* changed prefix to drm/amdgpu
--- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +1 -1
@@ -823,7 +823,7 @@ struct amdgpu_bo *amdgpu_bo_ref(struct amdgpu_bo *bo)if (bo ==NULL )return NULL ; -ttm_bo_reference (&bo->tbo); +ttm_bo_get (&bo->tbo);return bo; }
Signature · 6 lines
2.18.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 2/2 drm/amdgpu: Replace ttm_bo_unref with ttm_bo_put
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put.
A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. This is not necessary in most cases and sometimes even worked around by the calling code. A call to ttm_bo_put only releases the reference without clearing the pointer.
The current behaviour of cleaning the pointer is kept in the calling code, but should be removed if not required in a later patch.
v2:
* set prefix to drm/amdgpu
--- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c +2 -3
@@ -841,9 +841,8 @@ void amdgpu_bo_unref(struct amdgpu_bo **bo)return ; tbo = &((*bo)->tbo); -ttm_bo_unref (&tbo); -if (tbo ==NULL ) - *bo =NULL ; +ttm_bo_put (tbo); + *bo =NULL ; }/**
Signature · 6 lines
2.18.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 5 lines · Thomas Zimmermann
This patchset replaces ttm_bo_{reference/unref} with ttm_bo_{get,put}, which follow Linux' conventions for ref-counting functions.
v2:
* use prefix drm/amdgpu
I guess Chritian will help to fix the subject prefix, you actually needn't send them again :-)
Thanks,
Ray
Quoted 8 lines
Thomas Zimmermann (2):
drm/amdgpu: Replacettm_bo_referencewithttm_bo_getdrm/amdgpu: Replacettm_bo_unrefwithttm_bo_putdrivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
Quoted 7 lines
--
2.18.0_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx