Skip to contentSkip to conversation

nfsd: Mark expected switch fall-through

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Aug 1, 2018

Subsystems (2)
NFS client NFS server
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 nfsd: Mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Warning level 2 was used: -Wimplicit-fallthrough=2

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 fs/nfsd/nfs4callback.c | 1 +
 1 file changed, 1 insertion(+)
fs/nfsd/nfs4callback.c +1 -0
index 2a979aa9..5dd56e9 100644
@@ -1078,6 +1078,7 @@ static bool nfsd4_cb_sequence_done(struct rpc_task *task, struct nfsd4_callback
 		break;
 	case -ESERVERFAULT:
 		++session->se_cb_seq_nr;
+		/* Fall through */
 	case 1:
 	case -NFS4ERR_BADSESSION:
 		nfsd4_mark_cb_fault(cb->cb_clp, cb->cb_seq_status);
Signature · 1 line
2.7.4
#1 lore raw
Quoted 2 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Thanks, applying for 2.19.

--b.

Quoted 22 lines

Warning level 2 was used: -Wimplicit-fallthrough=2

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 fs/nfsd/nfs4callback.c | 1 +
 1 file changed, 1 insertion(+)
fs/nfsd/nfs4callback.c +1 -0
index 2a979aa9..5dd56e9 100644
@@ -1078,6 +1078,7 @@ static bool nfsd4_cb_sequence_done(struct rpc_task *task, struct nfsd4_callback
 		break;
 	case -ESERVERFAULT:
 		++session->se_cb_seq_nr;
+		/* Fall through */
 	case 1:
 	case -NFS4ERR_BADSESSION:
 		nfsd4_mark_cb_fault(cb->cb_clp, cb->cb_seq_status);
Signature · 1 line
2.7.4