Skip to contentSkip to conversation

ram: stm32_sdram: Adds stm32f746-disco fix for HardFault at booting

PATCH New Mark Olsson 2 participants 3 messages Aug 1, 2018 – Aug 2, 2018 1 message not in the archive Arm STM32

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Mark Olsson

author
#1 lore raw

PATCH 1/1 ram: stm32_sdram: Adds stm32f746-disco fix for HardFault at booting

- changes ram start address to 0xC0000000

Signed-off-by Mark Olsson <[email protected]>
Cc Vipin Kumar <[email protected]>
---
 include/configs/stm32f746-disco.h | 2 ++
 1 file changed, 2 insertions(+)
 mode change 100644 => 100755 include/configs/stm32f746-disco.h
include/configs/stm32f746-disco.h +2 -0
old mode 100644
new mode 100755
index 567e7f2a00..238d4e939f
@@ -21,6 +21,8 @@
  * Configuration of the external SDRAM memory
  */
 #define CONFIG_NR_DRAM_BANKS		1
+#define CONFIG_SYS_RAM_BASE		0xC0000000
+#define CONFIG_SYS_SDRAM_BASE		CONFIG_SYS_RAM_BASE
 
 #define CONFIG_SYS_MAX_FLASH_SECT	8
 #define CONFIG_SYS_MAX_FLASH_BANKS	1
Signature · 1 line
2.17.1
#2 lore raw

PATCH 1/1 ram: stm32_sdram: Adds stm32f746-disco fix for HardFault at booting

Hi Mark

+Vikas

Quoted 1 line · Mark Olsson

- changes ram start address to 0xC0000000

In the commit header, indicate that this patch is a fix

Indicates also in the commit message that this patch fixes a regression by adding the commit which brings this regression :

Commit 1473b12ad0b3 ("lib: fdtdec: Update ram_base to store ram start adddress") blablabla

Quoted 3 lines
Signed-off-by Mark Olsson <[email protected]>
Cc Vipin Kumar <[email protected]>

For information, don't forget to add maintainers in To: by using get_maintainer script as following:

./scripts/get_maintainer.pl -f include/configs/stm32f746-disco.h Vikas Manocha <[email protected]> (maintainer:STM32F746 DISCOVERY BOARD) u-boot at lists.denx.de (open list)

Quoted 13 lines
---
  include/configs/stm32f746-disco.h | 2 ++
  1 file changed, 2 insertions(+)

mode change 100644 => 100755 include/configs/stm32f746-disco.h

include/configs/stm32f746-disco.h +0 -0
old mode 100644
new mode 100755
index 567e7f2a00..238d4e939f

include/configs/stm32f746-disco.h line 28

Quoted 8 lines
include/configs/stm32f746-disco.h +2 -0
@@ -21,6 +21,8 @@
   * Configuration of the external SDRAM memory
   */
  #define CONFIG_NR_DRAM_BANKS		1
+#define CONFIG_SYS_RAM_BASE		0xC0000000
+#define CONFIG_SYS_SDRAM_BASE		CONFIG_SYS_RAM_BASE
 
  #define CONFIG_SYS_MAX_FLASH_SECT	8
  #define CONFIG_SYS_MAX_FLASH_BANKS	1

Thanks for your patch.

Patrice

#3 lore raw

PATCH 1/1 ram: stm32_sdram: Adds stm32f746-disco fix for HardFault at booting

Hi again Mark ;-)

I dig into this issue and i think a better fix must be done directly into the board/st/stm32f746-disco/stm32f746-disco.c.

At the same occasion, some cleaning can be done using last fdtdec_xxx() API.

I will submit a patch for that which fix the issue you saw.

Thanks

Patrice

Quoted 58 lines · Patrice CHOTARD

Hi Mark

+Vikas

Quoted 1 line · Mark Olsson

- changes ram start address to 0xC0000000

In the commit header, indicate that this patch is a fix

Indicates also in the commit message that this patch fixes a regression by adding the commit which brings this regression :

Commit 1473b12ad0b3 ("lib: fdtdec: Update ram_base to store ram start adddress") blablabla

Quoted 3 lines
Signed-off-by Mark Olsson <[email protected]>
Cc Vipin Kumar <[email protected]>

For information, don't forget to add maintainers in To: by using get_maintainer script as following:

./scripts/get_maintainer.pl -f include/configs/stm32f746-disco.h Vikas Manocha <[email protected]> (maintainer:STM32F746 DISCOVERY BOARD) u-boot at lists.denx.de (open list)

Quoted 13 lines
---
   include/configs/stm32f746-disco.h | 2 ++
   1 file changed, 2 insertions(+)

mode change 100644 => 100755 include/configs/stm32f746-disco.h

include/configs/stm32f746-disco.h +0 -0
old mode 100644
new mode 100755
index 567e7f2a00..238d4e939f

include/configs/stm32f746-disco.h line 28

Quoted 8 lines
include/configs/stm32f746-disco.h +2 -0
@@ -21,6 +21,8 @@
    * Configuration of the external SDRAM memory
    */
   #define CONFIG_NR_DRAM_BANKS		1
+#define CONFIG_SYS_RAM_BASE		0xC0000000
+#define CONFIG_SYS_SDRAM_BASE		CONFIG_SYS_RAM_BASE
 
   #define CONFIG_SYS_MAX_FLASH_SECT	8
   #define CONFIG_SYS_MAX_FLASH_BANKS	1

Thanks for your patch.

Patrice
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot