nfsd: use true and false for boolean values
Subsystems (2)
PATCH 1/1 nfsd: use true and false for boolean values
Return statements in functions returning bool should use true or false instead of an integer value.
This issue was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- fs/nfsd/nfsfh.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
fs/nfsd/nfsfh.c +3 -3
@@ -451,7 +451,7 @@ static bool fsid_type_ok_for_exp(u8 fsid_type, struct svc_export *exp)switch (fsid_type) {case FSID_DEV :if (!old_valid_dev (exp_sb (exp)->s_dev)) -return 0 ; +return false;/* FALL THROUGH */ case FSID_MAJOR_MINOR :case FSID_ENCODE_DEV :
@@ -461,13 +461,13 @@ static bool fsid_type_ok_for_exp(u8 fsid_type, struct svc_export *exp)case FSID_UUID8 :case FSID_UUID16 :if (!is_root_export (exp)) -return 0 ; +return false;/* fall through */ case FSID_UUID4_INUM :case FSID_UUID16_INUM :return exp->ex_uuid !=NULL ; } -return 1 ; +return true; }
Signature · 1 line
2.7.4
OK, applied for for-4.19, thanks.--b.
Quoted 41 lines · Gustavo A. R. Silva
Return statements in functions returning bool should use true or false instead of an integer value.
This issue was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>--- fs/nfsd/nfsfh.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)fs/nfsd/nfsfh.c +3
-3@@ -451,7 +451,7 @@ static bool fsid_type_ok_for_exp(u8 fsid_type, struct svc_export *exp)switch (fsid_type) {case FSID_DEV :if (!old_valid_dev (exp_sb (exp)->s_dev)) -return 0 ; +return false;/* FALL THROUGH */ case FSID_MAJOR_MINOR :case FSID_ENCODE_DEV :@@ -461,13 +461,13 @@ static bool fsid_type_ok_for_exp(u8 fsid_type, struct svc_export *exp)case FSID_UUID8 :case FSID_UUID16 :if (!is_root_export (exp)) -return 0 ; +return false;/* fall through */ case FSID_UUID4_INUM :case FSID_UUID16_INUM :return exp->ex_uuid !=NULL ; } -return 1 ; +return true; }Signature · 1 line
2.7.4