Skip to contentSkip to conversation

android: binder: Rate-limit debug and userspace triggered err msgs

PATCH New Sherry Yang 1 participant 1 message Aug 7, 2018 1 message not in the archive Android drivers

lore
Share & tools
lore
#1 lore raw

PATCH v2 1/1 android: binder: Rate-limit debug and userspace triggered err msgs

In reply to a message not in the archive

Use rate-limited debug messages where userspace can trigger excessive log spams.

---
v2: rebase onto char-misc-next to resolve include order difference from master

 drivers/android/binder.c       |  5 +++--
 drivers/android/binder_alloc.c | 41 +++++++++++++++++++++-------------
 2 files changed, 29 insertions(+), 17 deletions(-)
drivers/android/binder.c +3 -2
index 1cc2fa16af8b..d58763b6b009 100644
@@ -70,6 +70,7 @@
 #include <linux/pid_namespace.h>
 #include <linux/security.h>
 #include <linux/spinlock.h>
+#include <linux/ratelimit.h>
 
 #include <uapi/linux/android/binder.h>
 
@@ -163,13 +164,13 @@ module_param_call(stop_on_user_error, binder_set_stop_on_user_error,
 #define binder_debug(mask, x...) \
 	do { \
 		if (binder_debug_mask & mask) \
-			pr_info(x); \
+			pr_info_ratelimited(x); \
 	} while (0)
 
 #define binder_user_error(x...) \
 	do { \
 		if (binder_debug_mask & BINDER_DEBUG_USER_ERROR) \
-			pr_info(x); \
+			pr_info_ratelimited(x); \
 		if (binder_stop_on_user_error) \
 			binder_stop_on_user_error = 2; \
 	} while (0)
drivers/android/binder_alloc.c +26 -15

93 lines not on this page · raw message

Signature · 1 line
2.18.0.597.ga71716f1ad-goog