First patch
Hi guys,
I created my first patch. Could you please take a look
and check for mistakes? It's a small clean up removing checkpatch.pl warnings. It was generated using 'git format-patch master..<mybranch>'. See below:
Quoted 1 line
From
231fa77d595536cdaacf364b02dd64fd45a6adc4Mon Sep 17 00:00:00 2001
From: Arkadiusz Lis <[email protected]>
Date: Thu, 2 Aug 2018 23:38:17 +0200
Subject: [PATCH] Staging: One Laptop Per Child: fix coding style and license
issues
Add argument names to the function pointers in struct dcon_platform_data.
Add SPDX-License-Identifiers to the source files.
--- drivers/staging/olpc_dcon/olpc_dcon.c | 1 + drivers/staging/olpc_dcon/olpc_dcon.h | 6 +++--- drivers/staging/olpc_dcon/olpc_dcon_xo_1.c | 1 + drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c | 1 + 4 files changed, 6 insertions(+), 3 deletions(-)
drivers/staging/olpc_dcon/olpc_dcon.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Mainly by David Woodhouse, somewhat modified by Jordan Crouse *
drivers/staging/olpc_dcon/olpc_dcon.h +3 -3
@@ -91,10 +91,10 @@ struct dcon_priv { };struct dcon_platform_data { -int (*init)(struct dcon_priv *); +int (*init)(struct dcon_priv *dcon);void (*bus_stabilize_wiggle)(void ); -void (*set_dconload)(int ); -int (*read_status)(u8 *); +void (*set_dconload)(int val); +int (*read_status)(u8 *status); };#include <linux/interrupt.h>
drivers/staging/olpc_dcon/olpc_dcon_xo_1.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Mainly by David Woodhouse, somewhat modified by Jordan Crouse *
drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Copyright (c) 2009,2010 One Laptop per Child *
--
1.9.1
Quoted 5 lines · Arkadiusz Lis
From
231fa77d595536cdaacf364b02dd64fd45a6adc4Mon Sep 17 00:00:00 2001
From: Arkadiusz Lis <[email protected]>
Date: Thu, 2 Aug 2018 23:38:17 +0200
Subject: [PATCH] Staging: One Laptop Per Child: fix coding style and license
issues
One thing per patch. That's two things, therefor....
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 486 bytes
Desc: not available
URL: <http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20180803/8131de0f/attachment.sig>