gpu: drm: radeon: si: Replace mdelay() with msleep() in si_pcie_gen3_enable()
Subsystems (2)
PATCH 1/1 gpu: drm: radeon: si: Replace mdelay() with msleep() in si_pcie_gen3_enable()
si_pcie_gen3_enable() is never called in atomic context. It calls mdelay() to busily wait, which is not necessary. mdelay() can be replaced with msleep().
This is found by a static analysis tool named DCNS written by myself
--- drivers/gpu/drm/radeon/si.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/radeon/si.c +1 -1
@@ -7181,7 +7181,7 @@ static void si_pcie_gen3_enable(struct radeon_device *rdev) tmp |=LC_REDO_EQ ;WREG32_PCIE_PORT (PCIE_LC_CNTL4 , tmp); -mdelay (100 ); +msleep (100 );/* linkctl */ pci_read_config_word (root, bridge_pos +PCI_EXP_LNKCTL , &tmp16);
Signature · 1 line
2.17.0
Alex Deucher
AppliedQuoted 7 lines · Jia-Ju Bai
si_pcie_gen3_enable()is never called in atomic context. It callsmdelay()to busily wait, which is not necessary.mdelay()can be replaced withmsleep().This is found by a static analysis tool named DCNS written by myself
Signed-off-by Jia-Ju Bai <[email protected]>
Applied. thanks!
Alex
Quoted 20 lines
--- drivers/gpu/drm/radeon/si.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/radeon/si.c +1
-2@@ -7181,7 +7181,7 @@ static void si_pcie_gen3_enable(struct radeon_device *rdev) tmp |=LC_REDO_EQ ;WREG32_PCIE_PORT (PCIE_LC_CNTL4 , tmp); -mdelay (100 ); +msleep (100 );/* linkctl */ pci_read_config_word (root, bridge_pos +PCI_EXP_LNKCTL , &tmp16); --2.17.0
Quoted 4 lines
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx