Skip to contentSkip to conversation

staging: rtl8188eu: rename rtw_IOL_applied

PATCH New Michael Straube 1 participant 4 messages Aug 4, 2018 Staging

lore
Share & tools
lore

Michael Straube

author
#0 lore raw

PATCH 1/4 staging: rtl8188eu: rename rtw_IOL_applied

Rename rtw_IOL_applied to be all lowercase.
rtw_IOL_applied -> rtw_iol_applied

Signed-off-by Michael Straube <[email protected]>
---
 drivers/staging/rtl8188eu/core/rtw_efuse.c        | 2 +-
 drivers/staging/rtl8188eu/core/rtw_iol.c          | 2 +-
 drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 4 ++--
 drivers/staging/rtl8188eu/include/rtw_iol.h       | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)
drivers/staging/rtl8188eu/core/rtw_efuse.c +1 -1
index b19aa26d1705..0fd306a808c4 100644
@@ -298,7 +298,7 @@ static s32 iol_read_efuse(struct adapter *padapter, u8 txpktbuf_bndy, u16 offset
 
 void efuse_ReadEFuse(struct adapter *Adapter, u8 efuseType, u16 _offset, u16 _size_byte, u8 *pbuf)
 {
-	if (rtw_IOL_applied(Adapter)) {
+	if (rtw_iol_applied(Adapter)) {
 		rtw_hal_power_on(Adapter);
 		iol_mode_enable(Adapter, 1);
 		iol_read_efuse(Adapter, 0, _offset, _size_byte, pbuf);
drivers/staging/rtl8188eu/core/rtw_iol.c +1 -1
index 6b97e9f2a77b..f7a86eac738e 100644
@@ -7,7 +7,7 @@
 
 #include <rtw_iol.h>
 
-bool rtw_IOL_applied(struct adapter *adapter)
+bool rtw_iol_applied(struct adapter *adapter)
 {
 	if (adapter->registrypriv.fw_iol == 1)
 		return true;
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c +2 -2
index 8e7190b98692..607170775fa5 100644
@@ -75,7 +75,7 @@ s32 rtl8188e_iol_efuse_patch(struct adapter *padapter)
 	s32	result = _SUCCESS;
 
 	DBG_88E("==> %s\n", __func__);
-	if (rtw_IOL_applied(padapter)) {
+	if (rtw_iol_applied(padapter)) {
 		iol_mode_enable(padapter, 1);
 		result = iol_execute(padapter, CMD_READ_EFUSE_MAP);
 		if (result == _SUCCESS)

@@ -207,7 +207,7 @@ s32 InitLLTTable(struct adapter *padapter, u8 txpktbuf_bndy)
 	u32	i;
 	u32	Last_Entry_Of_TxPktBuf = LAST_ENTRY_OF_TX_PKT_BUFFER;/*  176, 22k */
 
-	if (rtw_IOL_applied(padapter)) {
+	if (rtw_iol_applied(padapter)) {
 		status = iol_InitLLTTable(padapter, txpktbuf_bndy);
 	} else {
 		for (i = 0; i < (txpktbuf_bndy - 1); i++) {
drivers/staging/rtl8188eu/include/rtw_iol.h +1 -1
index 53f5fe210e7b..f20b35e8d0a2 100644
@@ -10,6 +10,6 @@
 #include <osdep_service.h>
 #include <drv_types.h>
 
-bool rtw_IOL_applied(struct adapter  *adapter);
+bool rtw_iol_applied(struct adapter *adapter);
 
 #endif /* __RTW_IOL_H_ */
Signature · 1 line
2.18.0
author
#1 lore raw

PATCH 2/4 staging: rtl8188eu: remove unnecessary parentheses

Remove unnecessary parentheses from if conditions.

Signed-off-by Michael Straube <[email protected]>
---
 drivers/staging/rtl8188eu/core/rtw_iol.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8188eu/core/rtw_iol.c +2 -2
index f7a86eac738e..fc3c66201e59 100644
@@ -12,8 +12,8 @@ bool rtw_iol_applied(struct adapter *adapter)
 	if (adapter->registrypriv.fw_iol == 1)
 		return true;
 
-	if ((adapter->registrypriv.fw_iol == 2) &&
-	    (!adapter_to_dvobj(adapter)->ishighspeed))
+	if (adapter->registrypriv.fw_iol == 2 &&
+	    !adapter_to_dvobj(adapter)->ishighspeed)
 		return true;
 	return false;
 }
Signature · 1 line
2.18.0
author
#2 lore raw

PATCH 3/4 staging: rtl8188eu: remove redundant include

In reply to Michael Straube

The header osdep_service.h is included from drv_types.h, so remove the redundant include.

Signed-off-by Michael Straube <[email protected]>
---
 drivers/staging/rtl8188eu/include/rtw_iol.h | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/rtl8188eu/include/rtw_iol.h +0 -1
index f20b35e8d0a2..d713782d5cdc 100644
@@ -7,7 +7,6 @@
 #ifndef __RTW_IOL_H_
 #define __RTW_IOL_H_
 
-#include <osdep_service.h>
 #include <drv_types.h>
 
 bool rtw_iol_applied(struct adapter *adapter);
Signature · 1 line
2.18.0
author
#3 lore raw

PATCH 4/4 staging: rtl8188eu: remove unnecessary includes

In reply to Michael Straube

In the header rtw_iol.h there is only one function declared. Remove the include of rtw_iol.h from files that do not use this function.

Signed-off-by Michael Straube <[email protected]>
---
 drivers/staging/rtl8188eu/hal/mac_cfg.c        | 1 -
 drivers/staging/rtl8188eu/hal/phy.c            | 1 -
 drivers/staging/rtl8188eu/hal/usb_halinit.c    | 1 -
 drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 1 -
 4 files changed, 4 deletions(-)
drivers/staging/rtl8188eu/hal/mac_cfg.c +0 -1
index 8e849228f376..370aa5cc55a7 100644
@@ -7,7 +7,6 @@
 
 #include "odm_precomp.h"
 #include "phy.h"
-#include <rtw_iol.h>
 
 /* MAC_REG.TXT */
drivers/staging/rtl8188eu/hal/phy.c +0 -1
index 0fe2d53310f0..3c7cf8720df8 100644
@@ -8,7 +8,6 @@
 
 #include <osdep_service.h>
 #include <drv_types.h>
-#include <rtw_iol.h>
 #include <rtl8188e_hal.h>
 #include <rf.h>
 #include <phy.h>
drivers/staging/rtl8188eu/hal/usb_halinit.c +0 -1
index 56fda8005d38..12864b648fa8 100644
@@ -11,7 +11,6 @@
 #include <rtw_efuse.h>
 #include <fw.h>
 #include <rtl8188e_hal.h>
-#include <rtw_iol.h>
 #include <phy.h>
 
 #define		HAL_BB_ENABLE		1
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c +0 -1
index 19387d87185d..bee3c3a7a7a9 100644
@@ -19,7 +19,6 @@
 #include <rtw_ioctl_set.h>
 #include <rtl8188e_hal.h>
 
-#include <rtw_iol.h>
 #include <linux/vmalloc.h>
 #include <linux/etherdevice.h>
Signature · 1 line
2.18.0