drm/amdkfd: Use true and false for boolean values
Subsystems (3)
PATCH 1/1 drm/amdkfd: Use true and false for boolean values
Return statements in functions returning bool should use true or false instead of an integer value.
This code was detected with the help of Coccinelle.
--- drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c +2 -2
@@ -62,12 +62,12 @@ static bool cik_event_interrupt_isr(struct kfd_dev *dev, vmid = (ihre->ring_id &0x0000ff00 ) >>8 ;if (vmid < dev->vm_info.first_vmid_kfd || vmid > dev->vm_info.last_vmid_kfd) -return 0 ; +return false;/* If there is no valid PASID, it's likely a firmware bug */ pasid = (ihre->ring_id &0xffff0000 ) >>16 ;if (WARN_ONCE (pasid ==0 ,"FW bug: No PASID in KFD interrupt" )) -return 0 ; +return false;/* Interrupt types we care about: various signals and faults. * They will be forwarded to a work queue (see below).
Signature · 1 line
2.7.4
Quoted 6 lines · Gustavo A. R. Silva
Return statements in functions returning bool should use true or false instead of an integer value.
This code was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Looks good for me.
Add Felix for his awareness.
Quoted 30 lines
--- drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c +2
-2@@ -62,12 +62,12 @@ static bool cik_event_interrupt_isr(struct kfd_dev *dev, vmid = (ihre->ring_id &0x0000ff00 ) >>8 ;if (vmid < dev->vm_info.first_vmid_kfd || vmid > dev->vm_info.last_vmid_kfd) -return 0 ; +return false;/* If there is no valid PASID, it's likely a firmware bug */ pasid = (ihre->ring_id &0xffff0000 ) >>16 ;if (WARN_ONCE (pasid ==0 ,"FW bug: No PASID in KFD interrupt" )) -return 0 ; +return false;/* Interrupt types we care about: various signals and faults. * They will be forwarded to a work queue (see below). Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Thanks for that!
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Huang Rui
Sent: Tuesday, August 07, 2018 1:28 AM
To: Gustavo A. R. Silva <[email protected]>; Kuehling, Felix <[email protected]>
Cc: Oded Gabbay <[email protected]>; Zhou, David(ChunMing) <[email protected]>; David Airlie <[email protected]>; [email protected]; [email protected]; [email protected]; Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>
Subject: Re: [PATCH] drm/amdkfd: Use true and false for boolean values
Quoted 6 lines · Gustavo A. R. Silva
Return statements in functions returning bool should use true or false instead of an integer value.
This code was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Looks good for me.
Add Felix for his awareness.
Quoted 27 lines
--- drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c +2
-3@@ -62,12 +62,12 @@ static bool cik_event_interrupt_isr(struct kfd_dev *dev, vmid = (ihre->ring_id &0x0000ff00 ) >>8 ;if (vmid < dev->vm_info.first_vmid_kfd || vmid > dev->vm_info.last_vmid_kfd) -return 0 ; +return false;/* If there is no valid PASID, it's likely a firmware bug */ pasid = (ihre->ring_id &0xffff0000 ) >>16 ;if (WARN_ONCE (pasid ==0 ,"FW bug: No PASID in KFD interrupt" )) -return 0 ; +return false;/* Interrupt types we care about: various signals and faults. * They will be forwarded to a work queue (see below). -- 2.7.4
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel