Skip to contentSkip to conversation

ASoC: adau1761: Mark expected switch fall-though

PATCH In review Gustavo A. R. Silva 3 participants 3 messages Aug 8, 2018 – Aug 9, 2018

Subsystems (3)
Sound ASoC Analog devices inc ASoC codec drivers
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 ASoC: adau1761: Mark expected switch fall-though

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 114879 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 sound/soc/codecs/adau1761.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
sound/soc/codecs/adau1761.c +2 -1
index be136e9..bef3e9e 100644
@@ -518,7 +518,8 @@ static int adau1761_setup_digmic_jackdetect(struct snd_soc_component *component)
 			ARRAY_SIZE(adau1761_jack_detect_controls));
 		if (ret)
 			return ret;
-	case ADAU1761_DIGMIC_JACKDET_PIN_MODE_NONE: /* fallthrough */
+		/* fall through */
+	case ADAU1761_DIGMIC_JACKDET_PIN_MODE_NONE:
 		ret = snd_soc_dapm_add_routes(dapm, adau1761_no_dmic_routes,
 			ARRAY_SIZE(adau1761_no_dmic_routes));
 		if (ret)
Signature · 1 line
2.7.4
maintainer
#1 lore raw

sound/soc/codecs/adau1761.c static int adau1761_setup_digmic_jackdetect(struct snd_soc_component *component) · line 525

Quoted 10 lines · Gustavo A. R. Silva
sound/soc/codecs/adau1761.c +2 -1
@@ -518,7 +518,8 @@ static int adau1761_setup_digmic_jackdetect(struct snd_soc_component *component)
 			ARRAY_SIZE(adau1761_jack_detect_controls));
 		if (ret)
 			return ret;
-	case ADAU1761_DIGMIC_JACKDET_PIN_MODE_NONE: /* fallthrough */
+		/* fall through */
+	case ADAU1761_DIGMIC_JACKDET_PIN_MODE_NONE:
 		ret = snd_soc_dapm_add_routes(dapm, adau1761_no_dmic_routes,
 			ARRAY_SIZE(adau1761_no_dmic_routes));
 		if (ret)

Again, are you *sure* here?

maintainer Acked-by
#2 lore raw
Quoted 14 lines · Mark Brown

sound/soc/codecs/adau1761.c static int adau1761_setup_digmic_jackdetect(struct snd_soc_component *component) · line 525

Quoted 10 lines · Gustavo A. R. Silva
sound/soc/codecs/adau1761.c +2 -1
@@ -518,7 +518,8 @@ static int adau1761_setup_digmic_jackdetect(struct snd_soc_component *component)
 			ARRAY_SIZE(adau1761_jack_detect_controls));
 		if (ret)
 			return ret;
-	case ADAU1761_DIGMIC_JACKDET_PIN_MODE_NONE: /* fallthrough */
+		/* fall through */
+	case ADAU1761_DIGMIC_JACKDET_PIN_MODE_NONE:
 		ret = snd_soc_dapm_add_routes(dapm, adau1761_no_dmic_routes,
 			ARRAY_SIZE(adau1761_no_dmic_routes));
 		if (ret)

Again, are you *sure* here?

Well, it says so in the comment next to it :)

Acked-by Lars-Peter Clausen <[email protected]>