Skip to contentSkip to conversation

ALSA: opl3: Mark expected switch fall-through

PATCH Applied Gustavo A. R. Silva 2 participants 2 messages Aug 8, 2018 Sound

lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 ALSA: opl3: Mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 114878 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 sound/drivers/opl3/opl3_midi.c | 1 +
 1 file changed, 1 insertion(+)
sound/drivers/opl3/opl3_midi.c +1 -0
index 471916ca..a33cb74 100644
@@ -368,6 +368,7 @@ void snd_opl3_note_on(void *p, int note, int vel, struct snd_midi_channel *chan)
 			instr_4op = 1;
 			break;
 		}
+		/* fall through */
 	default:
 		spin_unlock_irqrestore(&opl3->voice_lock, flags);
 		return;
Signature · 1 line
2.7.4
Applied
#1 lore raw
Quoted 6 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 114878 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

Applied, thanks.

Takashi