ALSA: mixart_core: Mark expected switch fall-through
PATCH 1/1 ALSA: mixart_core: Mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Notice that in this particular case, I replaced the code comment with a proper "fall through" annotation, which is what GCC is expecting to find.
Addresses-Coverity-ID: 114889 ("Missing break in switch")
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- sound/pci/mixart/mixart_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/mixart/mixart_core.c +1 -1
@@ -540,7 +540,7 @@ irqreturn_t snd_mixart_threaded_irq(int irq, void *dev_id)dev_err (&mgr->pci->dev,"canceled notification %x !\n" , msg); } -/* no break, continue ! */ +/* fall through */ case MSG_TYPE_ANSWER :/* answer or notification to a message we are waiting for*/ mutex_lock (&mgr->msg_lock);
Signature · 1 line
2.7.4
Takashi Iwai
AppliedQuoted 10 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Notice that in this particular case, I replaced the code comment with a proper "fall through" annotation, which is what GCC is expecting to find.
Addresses-Coverity-ID: 114889 ("Missing break in switch")
Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied, thanks.
Takashi