Skip to contentSkip to conversation

common: fdt: set the value of MEMORY_BANKS_MAX to 8

PATCH New Anand Moon 3 participants 3 messages Aug 10, 2018 – Aug 17, 2018

lore
Share & tools
lore

Anand Moon

author
#0 lore raw

PATCH 1/1 common: fdt: set the value of MEMORY_BANKS_MAX to 8

set the value of MEMORY_BANKS_MAX to 8.
Odroid-XU4 fails to boot with following message

fdt_fixup_memory_banks: num banks 8 exceeds hardcoded limit 4. Recompile with higher MEMORY_BANKS_MAX?
ERROR: arch-specific fdt fixup failed
- must RESET the board to recover.

Fixes commit 2a1f4f1758b5 (Revert "fdt_support: Use CONFIG_NR_DRAM_BANKS if defined")
CC Ramon Fried <[email protected]>
CC Simon Glass <[email protected]>
Signed-off-by Anand Moon <[email protected]>
---
 common/fdt_support.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/fdt_support.c +1 -1
index 34d2bd59c4..ad87f31ab3 100644
@@ -409,7 +409,7 @@ static int fdt_pack_reg(const void *fdt, void *buf, u64 *address, u64 *size,
 	return p - (char *)buf;
 }
 
-#define MEMORY_BANKS_MAX 4
+#define MEMORY_BANKS_MAX 8
 int fdt_fixup_memory_banks(void *blob, u64 start[], u64 size[], int banks)
 {
 	int err, nodeoffset;
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 common: fdt: set the value of MEMORY_BANKS_MAX to 8

Quoted 27 lines · Anand Moon

set the value of MEMORY_BANKS_MAX to 8.
Odroid-XU4 fails to boot with following message

fdt_fixup_memory_banks: num banks 8 exceeds hardcoded limit 4. Recompile with higher MEMORY_BANKS_MAX?
ERROR: arch-specific fdt fixup failed
- must RESET the board to recover.

Fixes commit 2a1f4f1758b5 (Revert "fdt_support: Use CONFIG_NR_DRAM_BANKS

if defined")

CC Ramon Fried <[email protected]>
CC Simon Glass <[email protected]>
Signed-off-by Anand Moon <[email protected]>
---
 common/fdt_support.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/fdt_support.c +0 -0
index 34d2bd59c4..ad87f31ab3 100644
@@ -409,7 +409,7 @@ static int fdt_pack_reg(const void *fdt, void *buf,
 u64 *address, u64 *size,
        return p - (char *)buf;
 }
Quoted 1 line

I think it's better to check if MEMORY_BANKS was defined and only if not

to define it to 4.
Then users can define MEMORY_BANKS at include/configs/....h Simon, what do you say ?

-#define MEMORY_BANKS_MAX 4

Quoted 8 lines

+#define MEMORY_BANKS_MAX 8
int fdt_fixup_memory_banks(void *blob, u64 start[], u64 size[], int banks)

 {
        int err, nodeoffset;

--
2.17.1

#2 lore raw

PATCH 1/1 common: fdt: set the value of MEMORY_BANKS_MAX to 8

Hi,

Quoted 22 lines · Ramon Fried
Quoted 18 lines · Anand Moon

set the value of MEMORY_BANKS_MAX to 8.
Odroid-XU4 fails to boot with following message

fdt_fixup_memory_banks: num banks 8 exceeds hardcoded limit 4. Recompile with higher MEMORY_BANKS_MAX?
ERROR: arch-specific fdt fixup failed
- must RESET the board to recover.

Fixes commit 2a1f4f1758b5 (Revert "fdt_support: Use CONFIG_NR_DRAM_BANKS if defined")
CC Ramon Fried <[email protected]>
CC Simon Glass <[email protected]>
Signed-off-by Anand Moon <[email protected]>
---
 common/fdt_support.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 11 lines

common/fdt_support.c static int fdt_pack_reg(const void *fdt, void *buf, u64 *address, u64 *size, · line 411

Quoted 8 lines
common/fdt_support.c +0 -0
index 34d2bd59c4..ad87f31ab3 100644
@@ -409,7 +409,7 @@ static int fdt_pack_reg(const void *fdt, void *buf, u64 *address, u64 *size,
        return p - (char *)buf;
 }

I think it's better to check if MEMORY_BANKS was defined and only if not to define it to 4. Then users can define MEMORY_BANKS at include/configs/....h
Simon, what do you say ?

My vote is for Kconfig to define this, perhaps with a defaul of 4. But I see there is a lot of discussion and I have been out for a few weeks, so I don't have a strong opinion.

Quoted 9 lines
Quoted 9 lines
common/fdt_support.c +1 -2
-#define MEMORY_BANKS_MAX 4
+#define MEMORY_BANKS_MAX 8
 int fdt_fixup_memory_banks(void *blob, u64 start[], u64 size[], int banks)
 {
        int err, nodeoffset;
--

2.17.1

Regards,
Simon