Skip to contentSkip to conversation

staging: erofs: change 'unsigned' to 'unsigned int'

PATCH New Leon Imhof 3 participants 3 messages Aug 13, 2018 – Aug 16, 2018 Staging

lore
Share & tools
lore

Leon Imhof

author
#0 lore raw

PATCH 1/1 staging: erofs: change 'unsigned' to 'unsigned int'

Fix coding style issue "Prefer 'unsigned int' to bare use of 'unsigned'" detected by checkpatch.pl

Signed-off-by Leon Imhof <leon.imhof at in.tum.de>
---
 drivers/staging/erofs/data.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/erofs/data.c +1 -1
index ac263a180253..2a401216007a 100644
@@ -337,7 +337,7 @@ static int erofs_raw_access_readpage(struct file *file, struct page *page)
 
 static int erofs_raw_access_readpages(struct file *filp,
 	struct address_space *mapping,
-	struct list_head *pages, unsigned nr_pages)
+	struct list_head *pages, unsigned int nr_pages)
 {
 	erofs_off_t last_block;
 	struct bio *bio = NULL;
Signature · 1 line
2.18.0
#1 lore raw

PATCH 1/1 staging: erofs: change 'unsigned' to 'unsigned int'

Hi Leon,

Quoted 5 lines · Leon Imhof

Fix coding style issue "Prefer 'unsigned int' to bare use of 'unsigned'" detected by checkpatch.pl

Signed-off-by Leon Imhof <leon.imhof at in.tum.de>

---

Thanks for the patch, could be better if use [PATCH v2]' to indicate that you send a new version of [PATCH] staging: erofs: add int to usigned'.

Reviewed-by Gao Xiang <gaoxiang25 at huawei.com>

Thanks,
Gao Xiang

Quoted 17 lines
 drivers/staging/erofs/data.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/erofs/data.c +1 -1
index ac263a180253..2a401216007a 100644
@@ -337,7 +337,7 @@ static int erofs_raw_access_readpage(struct file *file, struct page *page)
 
 static int erofs_raw_access_readpages(struct file *filp,
 	struct address_space *mapping,
-	struct list_head *pages, unsigned nr_pages)
+	struct list_head *pages, unsigned int nr_pages)
 {
 	erofs_off_t last_block;
 	struct bio *bio = NULL;
#2 lore raw

PATCH 1/1 staging: erofs: change 'unsigned' to 'unsigned int'

In reply to Leon Imhof
Quoted 4 lines · Leon Imhof

Fix coding style issue "Prefer 'unsigned int' to bare use of 'unsigned'" detected by checkpatch.pl

Signed-off-by Leon Imhof <leon.imhof at in.tum.de>
Reviewed-by Chao Yu <yuchao0 at huawei.com>
Quoted 1 line

---

It would be better to indicate this patch is v2 one here and in subject-prefix.

Thanks,

Quoted 17 lines
 drivers/staging/erofs/data.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/erofs/data.c +1 -1
index ac263a180253..2a401216007a 100644
@@ -337,7 +337,7 @@ static int erofs_raw_access_readpage(struct file *file, struct page *page)
 
 static int erofs_raw_access_readpages(struct file *filp,
 	struct address_space *mapping,
-	struct list_head *pages, unsigned nr_pages)
+	struct list_head *pages, unsigned int nr_pages)
 {
 	erofs_off_t last_block;
 	struct bio *bio = NULL;