Skip to contentSkip to conversation

fsi: ast: select GENERIC_ALLOCATOR

PATCH In review Arnd Bergmann 2 participants 2 messages Aug 13, 2018 – Aug 14, 2018 FSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fsi: ast: select GENERIC_ALLOCATOR

In randconfig builds without CONFIG_GENERIC_ALLOCATOR, this driver fails to link:

ERROR: "gen_pool_alloc_algo" [drivers/fsi/fsi-master-ast-cf.ko] undefined!
ERROR: "gen_pool_fixed_alloc" [drivers/fsi/fsi-master-ast-cf.ko] undefined!
ERROR: "of_gen_pool_get" [drivers/fsi/fsi-master-ast-cf.ko] undefined!
ERROR: "gen_pool_free" [drivers/fsi/fsi-master-ast-cf.ko] undefined!

Select the dependency as all other users do.

Fixes 6a794a27daca ("fsi: master-ast-cf: Add new FSI master using Aspeed ColdFire")
---
 drivers/fsi/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/fsi/Kconfig +1 -0
index af3a20dd5aa4..99c99a5d57fe 100644
@@ -46,6 +46,7 @@ config FSI_MASTER_AST_CF
 	tristate "FSI master based on Aspeed ColdFire coprocessor"
 	depends on GPIOLIB
 	depends on GPIO_ASPEED
+	select GENERIC_ALLOCATOR
 	---help---
 	This option enables a FSI master using the AST2400 and AST2500 GPIO
 	lines driven by the internal ColdFire coprocessor. This requires
Signature · 1 line
2.18.0
#1 lore raw
Quoted 8 lines · Arnd Bergmann

In randconfig builds without CONFIG_GENERIC_ALLOCATOR, this driver fails to link:

ERROR: "gen_pool_alloc_algo" [drivers/fsi/fsi-master-ast-cf.ko] undefined!
ERROR: "gen_pool_fixed_alloc" [drivers/fsi/fsi-master-ast-cf.ko] undefined!
ERROR: "of_gen_pool_get" [drivers/fsi/fsi-master-ast-cf.ko] undefined!
ERROR: "gen_pool_free" [drivers/fsi/fsi-master-ast-cf.ko] undefined!

Quoted 5 lines

Select the dependency as all other users do.

Fixes 6a794a27daca ("fsi: master-ast-cf: Add new FSI master using Aspeed ColdFire")

---

Thanks, I'll pick it up and send to Greg with a slightly different subject

Cheers,
Ben.

Quoted 15 lines
 drivers/fsi/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/fsi/Kconfig +1 -0
index af3a20dd5aa4..99c99a5d57fe 100644
@@ -46,6 +46,7 @@ config FSI_MASTER_AST_CF
 	tristate "FSI master based on Aspeed ColdFire coprocessor"
 	depends on GPIOLIB
 	depends on GPIO_ASPEED
+	select GENERIC_ALLOCATOR
 	---help---
 	This option enables a FSI master using the AST2400 and AST2500 GPIO
 	lines driven by the internal ColdFire coprocessor. This requires