Skip to contentSkip to conversation

net: filter: mark expected switch fall-through

PATCH Applied Gustavo A. R. Silva 2 participants 2 messages Aug 14, 2018

Subsystems (4)
Networking Network drivers BPF BPF networking
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 net: filter: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 1472592 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 net/core/filter.c | 1 +
 1 file changed, 1 insertion(+)
net/core/filter.c +1 -0
index 15b9d2d..fd423ce 100644
@@ -7235,6 +7235,7 @@ sk_reuseport_is_valid_access(int off, int size,
 	case offsetof(struct sk_reuseport_md, eth_protocol):
 		if (size < FIELD_SIZEOF(struct sk_buff, protocol))
 			return false;
+		/* fall through */
 	case offsetof(struct sk_reuseport_md, ip_protocol):
 	case offsetof(struct sk_reuseport_md, bind_inany):
 	case offsetof(struct sk_reuseport_md, len):
Signature · 1 line
2.7.4
maintainer Applied
#1 lore raw

From: "Gustavo A. R. Silva" <[email protected]>
Date: Tue, 14 Aug 2018 11:20:21 -0500

Quoted 5 lines

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 1472592 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

Applied, thank you.