mtd: cfi_cmdset_0020: Mark expected switch fall-throughs
PATCH 1/1 mtd: cfi_cmdset_0020: Mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Addresses-Coverity-ID: 114857 ("Missing break in switch")
Addresses-Coverity-ID: 114858 ("Missing break in switch")
Addresses-Coverity-ID: 114859 ("Missing break in switch")
Addresses-Coverity-ID: 114860 ("Missing break in switch")
Addresses-Coverity-ID: 114861 ("Missing break in switch")
Addresses-Coverity-ID: 114862 ("Missing break in switch")
--- drivers/mtd/chips/cfi_cmdset_0020.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/mtd/chips/cfi_cmdset_0020.c +6 -0
@@ -324,6 +324,7 @@ static inline int do_read_onechip(struct map_info *map, struct flchip *chip, lofcase FL_JEDEC_QUERY :map_write (map,CMD (0x70 ), cmd_addr); chip->state =FL_STATUS ; +/* Fall through */ case FL_STATUS : status =map_read (map, cmd_addr);
@@ -461,6 +462,7 @@ static int do_write_buffer(struct map_info *map, struct flchip *chip,#ifdef DEBUG_CFI_FEATURES printk ("%s: 1 status[%x]\n" , __func__,map_read (map, cmd_adr));#endif +/* Fall through */ case FL_STATUS : status =map_read (map, cmd_adr);
@@ -754,6 +756,7 @@ static inline int do_erase_oneblock(struct map_info *map, struct flchip *chip, ucase FL_READY :map_write (map,CMD (0x70 ), adr); chip->state =FL_STATUS ; +/* Fall through */ case FL_STATUS : status =map_read (map, adr);
@@ -995,6 +998,7 @@ static void cfi_staa_sync (struct mtd_info *mtd)* as the whole point is that nobody can do anything * with the chip now anyway. */ +/* Fall through */ case FL_SYNCING :mutex_unlock (&chip->mutex);break ;
@@ -1050,6 +1054,7 @@ static inline int do_lock_oneblock(struct map_info *map, struct flchip *chip, uncase FL_READY :map_write (map,CMD (0x70 ), adr); chip->state =FL_STATUS ; +/* Fall through */ case FL_STATUS : status =map_read (map, adr);
@@ -1196,6 +1201,7 @@ static inline int do_unlock_oneblock(struct map_info *map, struct flchip *chip,case FL_READY :map_write (map,CMD (0x70 ), adr); chip->state =FL_STATUS ; +/* Fall through */ case FL_STATUS : status =map_read (map, adr);
Signature · 1 line
2.7.4
Boris Brezillon
AppliedQuoted 10 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Addresses-Coverity-ID: 114857 ("Missing break in switch")
Addresses-Coverity-ID: 114858 ("Missing break in switch")
Addresses-Coverity-ID: 114859 ("Missing break in switch")
Addresses-Coverity-ID: 114860 ("Missing break in switch")
Addresses-Coverity-ID: 114861 ("Missing break in switch")
Addresses-Coverity-ID: 114862 ("Missing break in switch")Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied to http://git.infradead.org/linux-mtd.git mtd/next, thanks.
Boris
Quoted 3 lines · Boris Brezillon
Applied to http://git.infradead.org/linux-mtd.git mtd/next, thanks.
Thanks, Boris.
--
Gustavo