Skip to contentSkip to conversation

dm: gpio: da8xx_gpio: Add support for GPIO_ACTIVE_LOW/HIGH

PATCH In review Adam Ford 2 participants 2 messages Aug 17, 2018 – Sep 18, 2018 GPIO

lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/1 dm: gpio: da8xx_gpio: Add support for GPIO_ACTIVE_LOW/HIGH

With DM and device tree support, let's use the GPIO_ACTIVE_HIGH and GPIO_ACTIVE_LOW from the device tree as they are intended.

drivers/gpio/da8xx_gpio.c +13 -0
index 3e95f039f0..f80bc6baf6 100644
@@ -493,12 +493,25 @@ static int davinci_gpio_get_function(struct udevice *dev, unsigned int offset)
 	return GPIOF_OUTPUT;
 }
 
+static int davinci_gpio_xlate(struct udevice *dev, struct gpio_desc *desc,
+			      struct ofnode_phandle_args *args)
+{
+	desc->offset = args->args[0];
+
+	if (args->args[1] & GPIO_ACTIVE_LOW)
+		desc->flags = GPIOD_ACTIVE_LOW;
+	else
+		desc->flags = 0;
+	return 0;
+}
+
 static const struct dm_gpio_ops gpio_davinci_ops = {
 	.direction_input	= davinci_gpio_direction_input,
 	.direction_output	= davinci_gpio_direction_output,
 	.get_value		= davinci_gpio_get_value,
 	.set_value		= davinci_gpio_set_value,
 	.get_function		= davinci_gpio_get_function,
+	.xlate			= davinci_gpio_xlate,
 };
 
 static int davinci_gpio_probe(struct udevice *dev)
Signature · 1 line
2.17.1
#1 lore raw

drivers/gpio/da8xx_gpio.c

Quoted 7 lines · Adam Ford

With DM and device tree support, let's use the GPIO_ACTIVE_HIGH and GPIO_ACTIVE_LOW from the device tree as they are intended.

drivers/gpio/da8xx_gpio.c +0 -0
index 3e95f039f0..f80bc6baf6 100644

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180918/13c97d44/attachment.sig>