Skip to contentSkip to conversation

staging: rtl8188eu: Removed code valid for 5GHz

PATCH Superseded Bhaskar Singh 2 participants 4 messages Aug 17, 2018 – Aug 20, 2018 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8188eu: Removed code valid for 5GHz

This patch removed code which are valid for IEEE 802.11a i.e. 5GHz.

This is also mention in the TODO file.

---
 drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
drivers/staging/rtl8188eu/core/rtw_ieee80211.c +1 -7
index 7d5cbaf50f1c..3ce20f381827 100644
@@ -100,19 +100,13 @@ bool rtw_is_cckratesonly_included(u8 *rate)
 
 int rtw_check_network_type(unsigned char *rate, int ratelen, int channel)
 {
-	if (channel > 14) {
-		if (rtw_is_cckrates_included(rate))
-			return WIRELESS_INVALID;
-		else
-			return WIRELESS_11A;
-	} else {  /*  could be pure B, pure G, or B/G */
+	  /*  could be pure B, pure G, or B/G */
 		if (rtw_is_cckratesonly_included(rate))
 			return WIRELESS_11B;
 		else if (rtw_is_cckrates_included(rate))
 			return	WIRELESS_11BG;
 		else
 			return WIRELESS_11G;
-	}
 }
 
 u8 *rtw_set_fixed_ie(void *pbuf, unsigned int len, void *source,
Signature · 1 line
2.16.4
#1 lore raw
Quoted 1 line · Bhaskar Singh

This patch removed code which are valid for IEEE 802.11a i.e. 5GHz.

I would be uncomfortable accepting this kind of change without an Ack from the maintainers.

The messes up the indenting so we can accept it anyway.

regards,
dan carpenter

#2 lore raw
Quoted 11 lines · Dan Carpenter
Quoted 1 line · Bhaskar Singh

This patch removed code which are valid for IEEE 802.11a i.e. 5GHz.

I would be uncomfortable accepting this kind of change without an Ack from the maintainers.

The messes up the indenting so we can accept it anyway.

regards,
dan carpenter

"find and remove remaining code valid only for 5 HGz. Most of the obvious ones have been removed, but things like channel > 14 still exist."
With due respect, I want to say that, the above thing is mention on the TODO list, please correct if I intrepreted that statement wrongly.

And Thanks a lot for finding indentation problem

Thanks,
Bhaskar Singh

#3 lore raw
Quoted 13 lines · Bhaskar Singh
Quoted 11 lines · Dan Carpenter
Quoted 1 line · Bhaskar Singh

This patch removed code which are valid for IEEE 802.11a i.e. 5GHz.

I would be uncomfortable accepting this kind of change without an Ack from the maintainers.

The messes up the indenting so we can accept it anyway.

regards,
dan carpenter

Quoted 6 lines

"find and remove remaining code valid only for 5 HGz. Most of the obvious ones have been removed, but things like channel > 14 still exist."
With due respect, I want to say that, the above thing is mention on the TODO list, please correct if I intrepreted that statement wrongly.

Yeah. I think you interpreted it correctly. That seems fine then. When I realized that we weren't going to merge the patch then I stopped reviewing without looking at the TODO.

When you resend the patch, please quote all the relevant information from the TODO so that we don't have to look for it:

This patch removes support for channels > 14. That is from the TODO which says:

- find and remove remaining code valid only for 5 HGz. Most of the obvious ones have been removed, but things like channel > 14 still exist.

regards,
dan carpenter