irqchip/gic-v3: Allow interrupt to be configured as wake-up sources
Subsystems (2)
PATCH 1/1 irqchip/gic-v3: Allow interrupt to be configured as wake-up sources
Although GICv3 doesn't directly offers support for wake-up interrupts and relies on external HW for this, it shouldn't prevent the driver for such HW from doing it work.
Let's set the required flags on the irq_chip structures.
---
Lina, please let me know how this goes. If that fixes your issues, I'll queue it as a fix for the current cycle.
drivers/irqchip/irq-gic-v3.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/irqchip/irq-gic-v3.c +6 -2
@@ -861,7 +861,9 @@ static struct irq_chip gic_chip = { .irq_set_affinity = gic_set_affinity, .irq_get_irqchip_state = gic_irq_get_irqchip_state, .irq_set_irqchip_state = gic_irq_set_irqchip_state, - .flags = IRQCHIP_SET_TYPE_MASKED, + .flags =IRQCHIP_SET_TYPE_MASKED | +IRQCHIP_SKIP_SET_WAKE | + IRQCHIP_MASK_ON_SUSPEND, };static struct irq_chip gic_eoimode1_chip = {
@@ -874,7 +876,9 @@ static struct irq_chip gic_eoimode1_chip = { .irq_get_irqchip_state = gic_irq_get_irqchip_state, .irq_set_irqchip_state = gic_irq_set_irqchip_state, .irq_set_vcpu_affinity = gic_irq_set_vcpu_affinity, - .flags = IRQCHIP_SET_TYPE_MASKED, + .flags =IRQCHIP_SET_TYPE_MASKED | +IRQCHIP_SKIP_SET_WAKE | + IRQCHIP_MASK_ON_SUSPEND, };#define GIC_ID_NR (1U << gic_data.rdists.id_bits)
Signature · 1 line
2.18.0
Quoted 6 lines · Marc Zyngier
Although GICv3 doesn't directly offers support for wake-up interrupts and relies on external HW for this, it shouldn't prevent the driver for such HW from doing it work.
Let's set the required flags on the
irq_chipstructures.
FWIW,
--
Regards,
Sudeep
Quoted 4 lines · Marc Zyngier
Although GICv3 doesn't directly offers support for wake-up interrupts and relies on external HW for this, it shouldn't prevent the driver for such HW from doing it work.
Quoted 8 lines
Let's set the required flags on the
irq_chipstructures.Reported-by Lina Iyer <[email protected]>Signed-off-by Marc Zyngier <[email protected]>---
Lina, please let me know how this goes. If that fixes your issues, I'll queue it as a fix for the current cycle.
Thanks for the quick turn around, Marc.
Quoted 32 lines
drivers/irqchip/irq-gic-v3.c| 8 ++++++--1 file changed, 6 insertions(+), 2 deletions(-)drivers/irqchip/irq-gic-v3.c +6
-3@@ -861,7 +861,9 @@ static struct irq_chip gic_chip = { .irq_set_affinity = gic_set_affinity, .irq_get_irqchip_state = gic_irq_get_irqchip_state, .irq_set_irqchip_state = gic_irq_set_irqchip_state, - .flags = IRQCHIP_SET_TYPE_MASKED, + .flags =IRQCHIP_SET_TYPE_MASKED | +IRQCHIP_SKIP_SET_WAKE | + IRQCHIP_MASK_ON_SUSPEND, };static struct irq_chip gic_eoimode1_chip = {@@ -874,7 +876,9 @@ static struct irq_chip gic_eoimode1_chip = { .irq_get_irqchip_state = gic_irq_get_irqchip_state, .irq_set_irqchip_state = gic_irq_set_irqchip_state, .irq_set_vcpu_affinity = gic_irq_set_vcpu_affinity, - .flags = IRQCHIP_SET_TYPE_MASKED, + .flags =IRQCHIP_SET_TYPE_MASKED | +IRQCHIP_SKIP_SET_WAKE | + IRQCHIP_MASK_ON_SUSPEND, };#define GIC_ID_NR (1U << gic_data.rdists.id_bits) --2.18.0