Skip to contentSkip to conversation

intel_punit_ipc: include linux/io.h

PATCH In review Arnd Bergmann 2 participants 2 messages Aug 17, 2018 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 intel_punit_ipc: include linux/io.h

After we stop including linux/irq.h implicitly, we don't see linux/io.h in intel_punit_ipc.c, leading to a build failure:

drivers/platform/x86/intel_punit_ipc.c: In function 'ipc_read_status':
drivers/platform/x86/intel_punit_ipc.c:55:9: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]

Add back the include that is clearly needed.

Fixes 447ae3166702 ("x86: Don't include linux/irq.h from asm/hardirq.h")
Cc Nicolai Stange <[email protected]>
Cc Thomas Gleixner <[email protected]>
---
 drivers/platform/x86/intel_punit_ipc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/intel_punit_ipc.c +1 -0
index f1afc0ebbc68..2efeab650345 100644
@@ -18,6 +18,7 @@
 #include <linux/bitops.h>
 #include <linux/device.h>
 #include <linux/interrupt.h>
+#include <linux/io.h>
 #include <linux/platform_device.h>
 #include <asm/intel_punit_ipc.h>
 
Signature · 1 line
2.18.0
#1 lore raw
Quoted 8 lines · Arnd Bergmann

After we stop including linux/irq.h implicitly, we don't see linux/io.h in intel_punit_ipc.c, leading to a build failure:

drivers/platform/x86/intel_punit_ipc.c: In function 'ipc_read_status':
drivers/platform/x86/intel_punit_ipc.c:55:9: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]

Add back the include that is clearly needed.

Thanks, Randy already sent a patch

Quoted 23 lines
Fixes 447ae3166702 ("x86: Don't include linux/irq.h from asm/hardirq.h")
Cc Nicolai Stange <[email protected]>
Cc Thomas Gleixner <[email protected]>
---
 drivers/platform/x86/intel_punit_ipc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/x86/intel_punit_ipc.c +1 -1
index f1afc0ebbc68..2efeab650345 100644
@@ -18,6 +18,7 @@
 #include <linux/bitops.h>
 #include <linux/device.h>
 #include <linux/interrupt.h>
+#include <linux/io.h>
 #include <linux/platform_device.h>
 #include <asm/intel_punit_ipc.h>
 
--

2.18.0

Signature · 2 lines
With Best Regards,
Andy Shevchenko