perf probe powerpc: Ignore SyS symbols irrespective of endianness
PATCH 1/1 perf probe powerpc: Ignore SyS symbols irrespective of endianness
This makes sure that the SyS symbols are ignored for any powerpc system, not just the big endian ones.
Fixes fb6d59423115 ("perf probe ppc: Use the right prefix when ignoring SyS symbols on ppc")
Reported-by Naveen N. Rao <[email protected]>
Signed-off-by Sandipan Das <[email protected]>
Reviewed-by Kamalesh Babulal <[email protected]>
--- tools/perf/arch/powerpc/util/sym-handling.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
tools/perf/arch/powerpc/util/sym-handling.c +3 -1
@@ -22,15 +22,16 @@ bool elf__needs_adjust_symbols(GElf_Ehdr ehdr)#endif -#if !defined(_CALL_ELF) || _CALL_ELF !=2 int arch__choose_best_symbol (struct symbol *syma,struct symbol *symb__maybe_unused ) {char *sym = syma->name; +#if !defined(_CALL_ELF) || _CALL_ELF !=2 /* Skip over any initial dot */ if (*sym =='.' ) sym++; +#endif /* Avoid "SyS" kernel syscall aliases */ if (strlen (sym) >=3 && !strncmp (sym,"SyS" ,3 ))
@@ -41,6 +42,7 @@ int arch__choose_best_symbol(struct symbol *syma,return SYMBOL_A ; } +#if !defined(_CALL_ELF) || _CALL_ELF !=2 /* Allow matching against dot variants */ int arch__compare_symbol_names (const char *namea,const char *nameb) {
Signature · 1 line
2.14.4
Quoted 10 lines · Sandipan Das
This makes sure that the SyS symbols are ignored for any powerpc system, not just the big endian ones.
Fixes fb6d59423115 ("perf probe ppc: Use the right prefix when ignoring SyS symbols on ppc")Reported-by Naveen N. Rao <[email protected]>Signed-off-by Sandipan Das <[email protected]>Reviewed-by Kamalesh Babulal <[email protected]>--- tools/perf/arch/powerpc/util/sym-handling.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
LGTM. Thanks for the fix.
Acked-by Naveen N. Rao <[email protected]>
- Naveen
Em Tue, Aug 28, 2018 at 02:49:15PM +0530, Naveen N. Rao escreveu:
Quoted 12 lines
Quoted 10 lines · Sandipan Das
This makes sure that the SyS symbols are ignored for any powerpc system, not just the big endian ones.
Fixes fb6d59423115 ("perf probe ppc: Use the right prefix when ignoring SyS symbols on ppc")Reported-by Naveen N. Rao <[email protected]>Signed-off-by Sandipan Das <[email protected]>Reviewed-by Kamalesh Babulal <[email protected]>--- tools/perf/arch/powerpc/util/sym-handling.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Quoted 2 lines
LGTM. Thanks for the fix.
Acked-by Naveen N. Rao <[email protected]>
Thanks, applied.
- Arnaldo
tip-bot for Sandipan Das
merge botperf probe powerpc: Ignore SyS symbols irrespective of endianness
Commit-ID: fa694160cca6dbba17c57dc7efec5f93feaf8795 Gitweb: https://git.kernel.org/tip/fa694160cca6dbba17c57dc7efec5f93feaf8795 Author: Sandipan Das <[email protected]> AuthorDate: Tue, 28 Aug 2018 14:38:48 +0530 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Thu, 30 Aug 2018 15:15:11 -0300
perf probe powerpc: Ignore SyS symbols irrespective of endianness
This makes sure that the SyS symbols are ignored for any powerpc system, not just the big endian ones.
Reported-by Naveen N. Rao <[email protected]>
Signed-off-by Sandipan Das <[email protected]>
Reviewed-by Kamalesh Babulal <[email protected]>
Acked-by Naveen N. Rao <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Ravi Bangoria <[email protected]>
Fixes fb6d59423115 ("perf probe ppc: Use the right prefix when ignoring SyS symbols on ppc")
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/arch/powerpc/util/sym-handling.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
tools/perf/arch/powerpc/util/sym-handling.c +3 -1
@@ -22,15 +22,16 @@ bool elf__needs_adjust_symbols(GElf_Ehdr ehdr)#endif -#if !defined(_CALL_ELF) || _CALL_ELF !=2 int arch__choose_best_symbol (struct symbol *syma,struct symbol *symb__maybe_unused ) {char *sym = syma->name; +#if !defined(_CALL_ELF) || _CALL_ELF !=2 /* Skip over any initial dot */ if (*sym =='.' ) sym++; +#endif /* Avoid "SyS" kernel syscall aliases */ if (strlen (sym) >=3 && !strncmp (sym,"SyS" ,3 ))
@@ -41,6 +42,7 @@ int arch__choose_best_symbol(struct symbol *syma,return SYMBOL_A ; } +#if !defined(_CALL_ELF) || _CALL_ELF !=2 /* Allow matching against dot variants */ int arch__compare_symbol_names (const char *namea,const char *nameb) {