Skip to contentSkip to conversation

drm/i915: make field unsigned

PATCH In review Lucas De Marchi 6 participants 17 messages Aug 28, 2018 – Oct 31, 2018 DRM drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drm/i915: make field unsigned

subvendor and subdevice are unsigned, so fix their initialization in INTEL_VGA_DEVICE.

---
 include/drm/i915_pciids.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/drm/i915_pciids.h +1 -1
index fd965ffbb92e..754ce4b10129 100644
@@ -37,7 +37,7 @@
  */
 #define INTEL_VGA_DEVICE(id, info) {		\
 	0x8086,	id,				\
-	~0, ~0,					\
+	~0u, ~0u,					\
 	0x030000, 0xff0000,			\
 	(unsigned long) info }
 
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH 2/2 drm/i915: reword documentation of possible pci_device_id struct

Document it like a real struct for ease of copy and paste, remove comment of C99 compatibility and document that in some cases the first 2 fields can be u16.

---
 include/drm/i915_pciids.h | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)
include/drm/i915_pciids.h +9 -7
index 754ce4b10129..0c2cc43f916c 100644
@@ -26,14 +26,16 @@
 #define _I915_PCIIDS_H
 
 /*
- * A pci_device_id struct {
- *	__u32 vendor, device;
- *      __u32 subvendor, subdevice;
- *	__u32 class, class_mask;
- *	kernel_ulong_t driver_data;
+ * These macros can be used with a struct declared like this:
+ *
+ * struct pci_device_id {
+ * 	__u32 vendor, device;
+ * 	__u32 subvendor, subdevice;
+ * 	__u32 class, class_mask;
+ * 	kernel_ulong_t driver_data;
  * };
- * Don't use C99 here because "class" is reserved and we want to
- * give userspace flexibility.
+ *
+ * First two fields may be __u16 if PCI_DEVICE_ANY is not used
  */
 #define INTEL_VGA_DEVICE(id, info) {		\
 	0x8086,	id,				\
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

Re: [PATCH 2/2] drm/i915: reword documentation of possible pci_device_id struct

Quoting Lucas De Marchi (2018-08-28 18:41:46)

Quoted 2 lines

Document it like a real struct for ease of copy and paste, remove comment of C99 compatibility and document that in some cases the first 2

I do recall that we couldn't use either C99 or class due to userspace compatibility... The essence is that we need a reminder that we can't assume the relaxed nature of kcc here.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

Re: [PATCH 2/2] drm/i915: reword documentation of possible pci_device_id struct

Quoted 5 lines · Chris Wilson

Quoting Lucas De Marchi (2018-08-28 18:41:46)

Quoted 2 lines

Document it like a real struct for ease of copy and paste, remove comment of C99 compatibility and document that in some cases the first 2

I do recall that we couldn't use either C99 or class due to userspace

you can't actually use a c++ compiler.

For C it works with any of -std=c99, gnu99, c11, gnu11, c17, gnu17. Tested with both gcc and clang. I've never heard of class being a reserved keyword and section 6.4.5 of said standard doesn't list it neither.

Here the struct definition is in a *comment*... i.e. the user will copy and paste somewhere else and probably change __u16 to uint16_t in userspace. If he's building with g++, he can name the field to something else.

If it was something we were defining in this header than I would agree with you... to retain compatibility with c++, not c99.

Lucas De Marchi

Quoted 3 lines

compatibility... The essence is that we need a reminder that we can't assume the relaxed nature of kcc here.
-Chris

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

Re: [PATCH 2/2] drm/i915: reword documentation of possible pci_device_id struct

Quoted 14 lines · Lucas De Marchi
Quoted 5 lines · Chris Wilson

Quoting Lucas De Marchi (2018-08-28 18:41:46)

Quoted 2 lines

Document it like a real struct for ease of copy and paste, remove comment of C99 compatibility and document that in some cases the first 2

I do recall that we couldn't use either C99 or class due to userspace

you can't actually use a c++ compiler.

For C it works with any of -std=c99, gnu99, c11, gnu11, c17, gnu17. Tested with both gcc and clang. I've never heard of class being a reserved keyword and section 6.4.5 of said standard doesn't list it neither.

Quoted 7 lines

Here the struct definition is in a *comment*... i.e. the user will copy and paste somewhere else and probably change __u16 to uint16_t in userspace. If he's building with g++, he can name the field to something else.

If it was something we were defining in this header than I would agree with you... to retain compatibility with c++, not c99.

I always thought the comment told you not to use designated initializers (introduced in C99), which would both impose a minimum C version requirement as well as bring .class = foo in the code, which requires more than just renaming the field with C++.

BR,
Jani.

Quoted 10 lines

Lucas De Marchi

Quoted 3 lines

compatibility... The essence is that we need a reminder that we can't assume the relaxed nature of kcc here.
-Chris

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#5 lore raw

Re: [PATCH 2/2] drm/i915: reword documentation of possible pci_device_id struct

In reply to Lucas De Marchi
Quoted 25 lines · Lucas De Marchi

Document it like a real struct for ease of copy and paste, remove comment of C99 compatibility and document that in some cases the first 2 fields can be u16.

---
 include/drm/i915_pciids.h | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)
include/drm/i915_pciids.h +2 -5
index 754ce4b10129..0c2cc43f916c 100644
@@ -26,14 +26,16 @@
 #define _I915_PCIIDS_H
 
 /*
- * A pci_device_id struct {
- *	__u32 vendor, device;
- *      __u32 subvendor, subdevice;
- *	__u32 class, class_mask;
- *	kernel_ulong_t driver_data;
+ * These macros can be used with a struct declared like this:
+ *

include/drm/i915_pciids.h line 38

Quoted 10 lines
include/drm/i915_pciids.h +7 -2
+ * struct pci_device_id {
+ * 	__u32 vendor, device;
+ * 	__u32 subvendor, subdevice;
+ * 	__u32 class, class_mask;
+ * 	kernel_ulong_t driver_data;
  * };
- * Don't use C99 here because "class" is reserved and we want to
- * give userspace flexibility.
+ *
+ * First two fields may be __u16 if PCI_DEVICE_ANY is not used

PCI_DEVICE_ANY undefined?

Also you can surely use u16 just fine as long as you're careful when comparing with ~0?

Quoted 10 lines
include/drm/i915_pciids.h +0 -0
  */
 #define INTEL_VGA_DEVICE(id, info) {		\
 	0x8086,	id,				\
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#6 lore raw

Re: [PATCH 2/2] drm/i915: reword documentation of possible pci_device_id struct

Quoted 30 lines · Ville Syrjälä
Quoted 29 lines · Lucas De Marchi

Document it like a real struct for ease of copy and paste, remove comment of C99 compatibility and document that in some cases the first 2 fields can be u16.

---
 include/drm/i915_pciids.h | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)
include/drm/i915_pciids.h +6 -5
index 754ce4b10129..0c2cc43f916c 100644
@@ -26,14 +26,16 @@
 #define _I915_PCIIDS_H
 
 /*
- * A pci_device_id struct {
- *	__u32 vendor, device;
- *      __u32 subvendor, subdevice;
- *	__u32 class, class_mask;
- *	kernel_ulong_t driver_data;
+ * These macros can be used with a struct declared like this:
+ *
+ * struct pci_device_id {
+ * 	__u32 vendor, device;
+ * 	__u32 subvendor, subdevice;
+ * 	__u32 class, class_mask;
Quoted 8 lines

include/drm/i915_pciids.h line 38

Quoted 6 lines
include/drm/i915_pciids.h +3 -2
+ * 	kernel_ulong_t driver_data;
  * };
- * Don't use C99 here because "class" is reserved and we want to
- * give userspace flexibility.
+ *
+ * First two fields may be __u16 if PCI_DEVICE_ANY is not used

PCI_DEVICE_ANY undefined?

this should be PCI_ANY_ID, but now I'm not sure if I should even mention it since it's defined somewhere that's private to kernel.

Quoted 3 lines

Also you can surely use u16 just fine as long as you're careful when comparing with ~0?

nops, since ~0u is unsigned int (~0 being int before patch 1), it will overflow and cause a warning due to -Woverflow. This is what happens in igt if I do what you said:

../intel/i915_pciids.h:40:2: warning: conversion from ‘unsigned int’ to ‘short unsigned int’ changes value from ‘4294967295’ to ‘65535’ [-Woverflow]
~0u, ~0u, \
^

Lucas De Marchi

Quoted 7 lines
Quoted 7 lines
include/drm/i915_pciids.h +0 -0
  */
 #define INTEL_VGA_DEVICE(id, info) {		\
 	0x8086,	id,				\
Signature · 1 line
2.17.1
Quoted 8 lines
Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 2 lines
Ville Syrjälä
Intel

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

PATCH v2 1/1 drm/i915: reword documentation of possible pci_device_id struct

In reply to Ville Syrjälä

Document it like a real struct for ease of copy and paste, remove comment of C99 compatibility and document that in some cases the first 2 fields can be u16.

v2: - remove mention to (non-existent) PCI_DEVICE_ANY and better explain
use of __u16 in first 2 fields

---
 include/drm/i915_pciids.h | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)
include/drm/i915_pciids.h +10 -7
index 754ce4b10129..0f15d7b2e8ea 100644
@@ -26,14 +26,17 @@
 #define _I915_PCIIDS_H
 
 /*
- * A pci_device_id struct {
- *	__u32 vendor, device;
- *      __u32 subvendor, subdevice;
- *	__u32 class, class_mask;
- *	kernel_ulong_t driver_data;
+ * These macros can be used with a struct declared like this:
+ *
+ * struct pci_device_id {
+ * 	__u32 vendor, device;
+ * 	__u32 subvendor, subdevice;
+ * 	__u32 class, class_mask;
+ * 	kernel_ulong_t driver_data;
  * };
- * Don't use C99 here because "class" is reserved and we want to
- * give userspace flexibility.
+ *
+ * This matches the struct used in the kernel. First two fields may be
+ * changed to __u16 if using this header in a userspace program.
  */
 #define INTEL_VGA_DEVICE(id, info) {		\
 	0x8086,	id,				\
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#8 lore raw

Re: [PATCH v2] drm/i915: reword documentation of possible pci_device_id struct

Quoted 7 lines · Lucas De Marchi

Document it like a real struct for ease of copy and paste, remove comment of C99 compatibility and document that in some cases the first 2 fields can be u16.

v2: - remove mention to (non-existent) PCI_DEVICE_ANY and better explain
use of __u16 in first 2 fields

ping review?

thanks
Lucas De Marchi

Quoted 43 lines
---
 include/drm/i915_pciids.h | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)
include/drm/i915_pciids.h +10 -8
index 754ce4b10129..0f15d7b2e8ea 100644
@@ -26,14 +26,17 @@
 #define _I915_PCIIDS_H
 
 /*
- * A pci_device_id struct {
- *     __u32 vendor, device;
- *      __u32 subvendor, subdevice;
- *     __u32 class, class_mask;
- *     kernel_ulong_t driver_data;
+ * These macros can be used with a struct declared like this:
+ *
+ * struct pci_device_id {
+ *     __u32 vendor, device;
+ *     __u32 subvendor, subdevice;
+ *     __u32 class, class_mask;
+ *     kernel_ulong_t driver_data;
  * };
- * Don't use C99 here because "class" is reserved and we want to
- * give userspace flexibility.
+ *
+ * This matches the struct used in the kernel. First two fields may be
+ * changed to __u16 if using this header in a userspace program.
  */
 #define INTEL_VGA_DEVICE(id, info) {           \
        0x8086, id,                             \
--

2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 5 lines
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#9 lore raw

✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: make field unsigned

In reply to Lucas De Marchi
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915: make field unsigned
URL : https://patchwork.freedesktop.org/series/48818/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
3def105ca25a drm/i915: make field unsigned
586500c7bf00 drm/i915: reword documentation of possible pci_device_id struct
-:30: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#30: FILE: include/drm/i915_pciids.h:32:
+ * ^I__u32 vendor, device;$

-:31: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #31: FILE: include/drm/i915_pciids.h:33:
+ * ^I__u32 subvendor, subdevice;$

-:32: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #32: FILE: include/drm/i915_pciids.h:34:
+ * ^I__u32 class, class_mask;$

-:33: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #33: FILE: include/drm/i915_pciids.h:35:
+ * ^Ikernel_ulong_t driver_data;$

total: 0 errors, 4 warnings, 0 checks, 23 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#10 lore raw

✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: make field unsigned

In reply to Lucas De Marchi
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915: make field unsigned
URL : https://patchwork.freedesktop.org/series/48818/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4718 -> Patchwork_10036 =

== Summary - SUCCESS ==

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/48818/revisions/1/mbox/

== Known issues ==

Here are the changes found in Patchwork_10036 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    {igt@amdgpu/amd_basic@userptr}:
      {fi-kbl-8809g}:     PASS -> INCOMPLETE (fdo#107402)

    igt@drv_selftest@live_hangcheck:
      fi-skl-6600u:       PASS -> DMESG-FAIL (fdo#106560, fdo#107174)

    igt@kms_frontbuffer_tracking@basic:
      {fi-byt-clapper}:   PASS -> FAIL (fdo#103167)

    igt@prime_vgem@basic-fence-flip:
      fi-ilk-650:         PASS -> FAIL (fdo#104008)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_hangcheck:
      {fi-cfl-8109u}:     DMESG-FAIL (fdo#106560) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

    {igt@kms_psr@primary_page_flip}:
      fi-cnl-psr:         FAIL (fdo#107336) -> PASS

    {igt@pm_rpm@module-reload}:
      fi-cnl-psr:         WARN (fdo#107602, fdo#107708) -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174
fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
fdo#107402 https://bugs.freedesktop.org/show_bug.cgi?id=107402
fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602
fdo#107708 https://bugs.freedesktop.org/show_bug.cgi?id=107708

== Participating hosts (54 -> 49) ==

Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u

== Build changes ==

* Linux: CI_DRM_4718 -> Patchwork_10036

CI_DRM_4718: c7398fd19cef9b11c79af7292109507b6be075c4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4611: b966dd93a30f41581fe1dbf9bc1c4a29b552ca05 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10036: 586500c7bf00e9295701c4df871a67a2a76f6cae @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

586500c7bf00 drm/i915: reword documentation of possible pci_device_id struct 3def105ca25a drm/i915: make field unsigned

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10036/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#11 lore raw

✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: make field unsigned

In reply to Lucas De Marchi
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915: make field unsigned
URL : https://patchwork.freedesktop.org/series/48818/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4718_full -> Patchwork_10036_full =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_10036_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10036_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_10036_full:

=== IGT changes ===

    ==== Warnings ====

    igt@kms_chv_cursor_fail@pipe-a-128x128-right-edge:
      shard-snb:          PASS -> SKIP +1

== Known issues ==

Here are the changes found in Patchwork_10036_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@kms_cursor_crc@cursor-64x64-suspend:
      shard-kbl:          PASS -> INCOMPLETE (fdo#107556, fdo#103665)

    igt@kms_flip@wf_vblank-ts-check-interruptible:
      shard-kbl:          PASS -> DMESG-WARN (fdo#103558, fdo#105602) +17

    igt@kms_setmode@basic:
      shard-kbl:          PASS -> DMESG-FAIL (fdo#103558, fdo#105602, fdo#99912)

    igt@perf@blocking:
      shard-hsw:          PASS -> FAIL (fdo#102252)

    
    ==== Possible fixes ====

    igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
      shard-glk:          FAIL (fdo#105454, fdo#106509) -> PASS

    igt@kms_draw_crc@draw-method-xrgb8888-blt-ytiled:
      shard-glk:          FAIL (fdo#107589) -> PASS

    igt@kms_flip@2x-flip-vs-expired-vblank:
      shard-glk:          FAIL (fdo#105363) -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-b:
      shard-glk:          DMESG-WARN (fdo#105763) -> PASS +1

fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
fdo#107589 https://bugs.freedesktop.org/show_bug.cgi?id=107589
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912

== Participating hosts (5 -> 5) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_4718 -> Patchwork_10036

CI_DRM_4718: c7398fd19cef9b11c79af7292109507b6be075c4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4611: b966dd93a30f41581fe1dbf9bc1c4a29b552ca05 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10036: 586500c7bf00e9295701c4df871a67a2a76f6cae @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10036/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#12 lore raw

✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: make field unsigned (rev2)

In reply to Lucas De Marchi
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915: make field unsigned (rev2)
URL : https://patchwork.freedesktop.org/series/48818/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
c39485603dc4 drm/i915: make field unsigned
6ee99a76cca9 drm/i915: reword documentation of possible pci_device_id struct
-:33: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#33: FILE: include/drm/i915_pciids.h:32:
+ * ^I__u32 vendor, device;$

-:34: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #34: FILE: include/drm/i915_pciids.h:33:
+ * ^I__u32 subvendor, subdevice;$

-:35: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #35: FILE: include/drm/i915_pciids.h:34:
+ * ^I__u32 class, class_mask;$

-:36: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #36: FILE: include/drm/i915_pciids.h:35:
+ * ^Ikernel_ulong_t driver_data;$

total: 0 errors, 4 warnings, 0 checks, 24 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#13 lore raw

Re: ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: make field unsigned (rev2)

Quoted 19 lines · Patchwork

== Series Details ==

Series: series starting with [1/2] drm/i915: make field unsigned (rev2)
URL : https://patchwork.freedesktop.org/series/48818/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
c39485603dc4 drm/i915: make field unsigned
6ee99a76cca9 drm/i915: reword documentation of possible pci_device_id struct
-:33: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#33: FILE: include/drm/i915_pciids.h:32:
+ * ^I__u32 vendor, device;$

-:34: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #34: FILE: include/drm/i915_pciids.h:33:
+ * ^I__u32 subvendor, subdevice;$

Quoted 7 lines

-:35: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #35: FILE: include/drm/i915_pciids.h:34:
+ * ^I__u32 class, class_mask;$

-:36: WARNING:SPACE_BEFORE_TAB: please, no space before tabs #36: FILE: include/drm/i915_pciids.h:35:
+ * ^Ikernel_ulong_t driver_data;$

Those are in a comment and the spaces are actually correct since it's part of the multline comment style.

Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#14 lore raw

✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: make field unsigned (rev2)

In reply to Lucas De Marchi
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915: make field unsigned (rev2)
URL : https://patchwork.freedesktop.org/series/48818/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4775 -> Patchwork_10103 =

== Summary - SUCCESS ==

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/48818/revisions/2/mbox/

== Known issues ==

Here are the changes found in Patchwork_10103 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@debugfs_test@read_all_entries:
      fi-kbl-7560u:       PASS -> INCOMPLETE (fdo#103665)

    igt@kms_flip@basic-flip-vs-wf_vblank:
      fi-bxt-dsi:         PASS -> INCOMPLETE (fdo#103927)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_coherency:
      fi-gdg-551:         DMESG-FAIL (fdo#107164) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-byt-clapper:     FAIL (fdo#103191, fdo#107362) -> PASS

fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362

== Participating hosts (54 -> 49) ==

Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u

== Build changes ==

* Linux: CI_DRM_4775 -> Patchwork_10103

CI_DRM_4775: 1a2bb6c061217718b972b3f4a74b96b61cf19d0c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4630: 86686c6e2f7c6f0944bced11550e06d20bc6957f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10103: 6ee99a76cca960284fc550b0d138a353f723f2e3 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

6ee99a76cca9 drm/i915: reword documentation of possible pci_device_id struct c39485603dc4 drm/i915: make field unsigned

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10103/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#15 lore raw

✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: make field unsigned (rev2)

In reply to Lucas De Marchi
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915: make field unsigned (rev2)
URL : https://patchwork.freedesktop.org/series/48818/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4775_full -> Patchwork_10103_full =

== Summary - SUCCESS ==

No regressions found.

== Known issues ==

Here are the changes found in Patchwork_10103_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@kms_flip@flip-vs-expired-vblank-interruptible:
      shard-glk:          PASS -> FAIL (fdo#105363, fdo#102887)

    
    ==== Possible fixes ====

    igt@gem_exec_big:
      shard-hsw:          INCOMPLETE (fdo#103540) -> PASS

    igt@kms_flip@modeset-vs-vblank-race-interruptible:
      shard-glk:          INCOMPLETE (fdo#103359, k.org#198133) -> PASS

fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133

== Participating hosts (5 -> 5) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_4775 -> Patchwork_10103

CI_DRM_4775: 1a2bb6c061217718b972b3f4a74b96b61cf19d0c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4630: 86686c6e2f7c6f0944bced11550e06d20bc6957f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10103: 6ee99a76cca960284fc550b0d138a353f723f2e3 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10103/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#16 lore raw
In reply to Lucas De Marchi

+Chris

Quoted 15 lines · Lucas De Marchi

subvendor and subdevice are unsigned, so fix their initialization in INTEL_VGA_DEVICE.

---
 include/drm/i915_pciids.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/drm/i915_pciids.h +0 -0
index fd965ffbb92e..754ce4b10129 100644

include/drm/i915_pciids.h line 40

Quoted 5 lines
include/drm/i915_pciids.h +1 -1
@@ -37,7 +37,7 @@
  */
 #define INTEL_VGA_DEVICE(id, info) {           \
        0x8086, id,                             \
-       ~0, ~0,                                 \
+       ~0u, ~0u,                                       \

This came from your suggestion in
https://patchwork.freedesktop.org/patch/245943/
"And then while you are there, add the missing 'u' to ~0u"

Should I resend this simple patch alone (since the second got nacked)?

thanks
Lucas De Marchi

Quoted 10 lines
include/drm/i915_pciids.h +0 -1
        0x030000, 0xff0000,                     \
        (unsigned long) info }
 
--

2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 5 lines
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx