Skip to contentSkip to conversation

amlogic: board p212: Fix Ethernet PHY init

PATCH New Jasper Kcoding 3 participants 4 messages Aug 28, 2018 – Sep 6, 2018

lore
Share & tools
lore

Jasper Kcoding

author
#0 lore raw

PATCH 1/1 amlogic: board p212: Fix Ethernet PHY init

Without this patch the Ethernet PHY on the p212 board does not get fully configured. When this happens Ethernet does not function.

The similar libretech-cc and khadas-vim boards have this code already. That's why the Ethernet on these boards do work.

---
 board/amlogic/p212/p212.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/amlogic/p212/p212.c +1 -1
index 06c2eaee47..d5ce5397f3 100644
@@ -29,7 +29,7 @@ int misc_init_r(void)
 	char serial[EFUSE_SN_SIZE];
 	ssize_t len;
 
-	meson_gx_eth_init(PHY_INTERFACE_MODE_RMII, 0);
+	meson_gx_eth_init(PHY_INTERFACE_MODE_RMII, MESON_GXL_USE_INTERNAL_RMII_PHY);
 
 	if (!eth_env_get_enetaddr("ethaddr", mac_addr)) {
 		len = meson_sm_read_efuse(EFUSE_MAC_OFFSET,
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 amlogic: board p212: Fix Ethernet PHY init

Hi jasper,

Quoted 5 lines · Jasper Kcoding

Without this patch the Ethernet PHY on the p212 board does not get fully configured. When this happens Ethernet does not function.

The similar libretech-cc and khadas-vim boards have this code already. That's why the Ethernet on these boards do work.

Please add a "Signed-off-by" tag.

Quoted 10 lines
---
 board/amlogic/p212/p212.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/amlogic/p212/p212.c +0 -0
index 06c2eaee47..d5ce5397f3 100644

board/amlogic/p212/p212.c int misc_init_r(void) · line 35

Quoted 8 lines
board/amlogic/p212/p212.c +1 -1
@@ -29,7 +29,7 @@ int misc_init_r(void)
 	char serial[EFUSE_SN_SIZE];
 	ssize_t len;
 
-	meson_gx_eth_init(PHY_INTERFACE_MODE_RMII, 0);
+	meson_gx_eth_init(PHY_INTERFACE_MODE_RMII, MESON_GXL_USE_INTERNAL_RMII_PHY);
 
 	if (!eth_env_get_enetaddr("ethaddr", mac_addr)) {
 		len = meson_sm_read_efuse(EFUSE_MAC_OFFSET,
Acked-by Neil Armstrong <[email protected]>

Please resend with my Acked-by tag !

Thanks for fixing this...

Neil

author
#2 lore raw

PATCH 1/1 amlogic: board p212: Fix Ethernet PHY init

In reply to Jasper Kcoding

Without this patch the Ethernet PHY on the p212 board does not get fully configured.
When this happens Ethernet does not function.

The similar libretech-cc and khadas-vim boards have this code already. That's why the Ethernet on these boards do work.

Signed-off-by Jasper Kcoding <[email protected]>
Acked-by Neil Armstrong <[email protected]>
---
 board/amlogic/p212/p212.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/amlogic/p212/p212.c +1 -1
index 06c2eaee47..d5ce5397f3 100644
@@ -29,7 +29,7 @@ int misc_init_r(void)
        char serial[EFUSE_SN_SIZE];
        ssize_t len;
 
-       meson_gx_eth_init(PHY_INTERFACE_MODE_RMII, 0);
+       meson_gx_eth_init(PHY_INTERFACE_MODE_RMII,

MESON_GXL_USE_INTERNAL_RMII_PHY);

if (!eth_env_get_enetaddr("ethaddr", mac_addr)) {
len = meson_sm_read_efuse(EFUSE_MAC_OFFSET,
--
2.11.0

#3 lore raw
Quoted 9 lines · Jasper kcoding

Without this patch the Ethernet PHY on the p212 board does not get fully configured.
When this happens Ethernet does not function.

The similar libretech-cc and khadas-vim boards have this code already. That's why the Ethernet on these boards do work.

Signed-off-by Jasper Kcoding <[email protected]>
Acked-by Neil Armstrong <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180906/406d104b/attachment.sig>