Skip to contentSkip to conversation

firmware: google: make structure gsmi_dev static

PATCH RESEND New Jean Delvare 1 participant 1 message Sep 3, 2018

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 firmware: google: make structure gsmi_dev static

From: Colin Ian King <[email protected]>
Subject: firmware: google: make structure gsmi_dev static

The structure gsmi_dev is local to the source and does not need to be in global scope, so make it static.

Cleans up sparse warning:
symbol 'gsmi_dev' was not declared. Should it be static?

---
Colin submitted this trivial patch twice already (2017-10-03, 2018-06-01) but nobody picked it. Greg, can you take this in one of your trees? Or should it go through Andrew? Thanks.

 drivers/firmware/google/gsmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/google/gsmi.c +1 -1
index c8f169bf2e27..734146eec1b9 100644
@@ -84,7 +84,7 @@ struct gsmi_buf {
 	u32 address;			/* physical address of buffer */
 };
 
-struct gsmi_device {
+static struct gsmi_device {
 	struct platform_device *pdev;	/* platform device */
 	struct gsmi_buf *name_buf;	/* variable name buffer */
 	struct gsmi_buf *data_buf;	/* generic data buffer */
Signature · 7 lines
2.14.1



-- 
Jean Delvare
SUSE L3 Support