vhost: fix VHOST_GET_BACKEND_FEATURES ioctl request definition
Subsystems (5)
PATCH 1/1 vhost: fix VHOST_GET_BACKEND_FEATURES ioctl request definition
The _IOC_READ flag fits this ioctl request more because this request actually only writes to, but doesn't read from userspace. See NOTEs in include/uapi/asm-generic/ioctl.h for more information.
--- include/uapi/linux/vhost.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/linux/vhost.h +1 -1
@@ -176,7 +176,7 @@ struct vhost_memory {#define VHOST_BACKEND_F_IOTLB_MSG_V2 0x1#define VHOST_SET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x25, __u64) -#define VHOST_GET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x26, __u64) +#define VHOST_GET_BACKEND_FEATURES _IOR(VHOST_VIRTIO, 0x26, __u64)/* VHOST_NET specific defines */
Signature · 1 line
glebfm
Michael S. Tsirkin
maintainerQuoted 6 lines · Gleb Fotengauer-Malinovskiy
The
_IOC_READflag fits this ioctl request more because this request actually only writes to, but doesn't read from userspace. See NOTEs ininclude/uapi/asm-generic/ioctl.hfor more information.Fixes 429711aec282 ("vhost: switch to use new message format")Signed-off-by Gleb Fotengauer-Malinovskiy <[email protected]>
Hmm it does make sense, and it's not too late to fix this up. Jason, what's your take on this? Was _IOW intentional?
Quoted 20 lines
--- include/uapi/linux/vhost.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/uapi/linux/vhost.h +1
-1@@ -176,7 +176,7 @@ struct vhost_memory {#define VHOST_BACKEND_F_IOTLB_MSG_V2 0x1#define VHOST_SET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x25, __u64) -#define VHOST_GET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x26, __u64) +#define VHOST_GET_BACKEND_FEATURES _IOR(VHOST_VIRTIO, 0x26, __u64)/* VHOST_NET specific defines */ Signature · 2 lines
-- glebfm
Jason Wang
Acked-byQuoted 9 lines · Michael S. Tsirkin
Quoted 6 lines · Gleb Fotengauer-Malinovskiy
The
_IOC_READflag fits this ioctl request more because this request actually only writes to, but doesn't read from userspace. See NOTEs ininclude/uapi/asm-generic/ioctl.hfor more information.Fixes 429711aec282 ("vhost: switch to use new message format")Signed-off-by Gleb Fotengauer-Malinovskiy <[email protected]>Hmm it does make sense, and it's not too late to fix this up. Jason, what's your take on this? Was
_IOWintentional?
My bad, not intentional. And I agree that fixing this is not too late.
So
Quoted 21 lines
Quoted 21 lines
--- include/uapi/linux/vhost.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/uapi/linux/vhost.h +1
-1@@ -176,7 +176,7 @@ struct vhost_memory {#define VHOST_BACKEND_F_IOTLB_MSG_V2 0x1#define VHOST_SET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x25, __u64) -#define VHOST_GET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x26, __u64) +#define VHOST_GET_BACKEND_FEATURES _IOR(VHOST_VIRTIO, 0x26, __u64)/* VHOST_NET specific defines */ Signature · 2 lines
-- glebfm
Jason Wang
Acked-byQuoted 9 lines · Michael S. Tsirkin
Quoted 6 lines · Gleb Fotengauer-Malinovskiy
The
_IOC_READflag fits this ioctl request more because this request actually only writes to, but doesn't read from userspace. See NOTEs ininclude/uapi/asm-generic/ioctl.hfor more information.Fixes 429711aec282 ("vhost: switch to use new message format")Signed-off-by Gleb Fotengauer-Malinovskiy <[email protected]>Hmm it does make sense, and it's not too late to fix this up. Jason, what's your take on this? Was
_IOWintentional?
My bad, not intentional. And I agree that fixing this is not too late.
So
Quoted 16 lines
Quoted 16 lines
--- include/uapi/linux/vhost.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/uapi/linux/vhost.h +1
-1@@ -176,7 +176,7 @@ struct vhost_memory {#define VHOST_BACKEND_F_IOTLB_MSG_V2 0x1#define VHOST_SET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x25, __u64) -#define VHOST_GET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x26, __u64) +#define VHOST_GET_BACKEND_FEATURES _IOR(VHOST_VIRTIO, 0x26, __u64)
Quoted 5 lines
Quoted 5 lines
include/uapi/linux/vhost.h +0
-0/* VHOST_NET specific defines */ Signature · 2 lines
-- glebfm
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Quoted 10 lines · Jason Wang
Quoted 7 lines · Michael S. Tsirkin
Quoted 6 lines · Gleb Fotengauer-Malinovskiy
The
_IOC_READflag fits this ioctl request more because this request actually only writes to, but doesn't read from userspace. See NOTEs ininclude/uapi/asm-generic/ioctl.hfor more information.Fixes 429711aec282 ("vhost: switch to use new message format")Signed-off-by Gleb Fotengauer-Malinovskiy <[email protected]>
Quoted 8 lines
Quoted 2 lines
Hmm it does make sense, and it's not too late to fix this up. Jason, what's your take on this? Was
_IOWintentional?My bad, not intentional. And I agree that fixing this is not too late.
So
Acked-by Jason Wang <[email protected]>
OK then
Quoted 18 lines
Quoted 18 lines
Quoted 18 lines
--- include/uapi/linux/vhost.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/uapi/linux/vhost.h +1
-2@@ -176,7 +176,7 @@ struct vhost_memory {#define VHOST_BACKEND_F_IOTLB_MSG_V2 0x1#define VHOST_SET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x25, __u64) -#define VHOST_GET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x26, __u64) +#define VHOST_GET_BACKEND_FEATURES _IOR(VHOST_VIRTIO, 0x26, __u64)/* VHOST_NET specific defines */ --glebfm
Quoted 10 lines · Jason Wang
Quoted 7 lines · Michael S. Tsirkin
Quoted 6 lines · Gleb Fotengauer-Malinovskiy
The
_IOC_READflag fits this ioctl request more because this request actually only writes to, but doesn't read from userspace. See NOTEs ininclude/uapi/asm-generic/ioctl.hfor more information.Fixes 429711aec282 ("vhost: switch to use new message format")Signed-off-by Gleb Fotengauer-Malinovskiy <[email protected]>
Quoted 8 lines
Quoted 2 lines
Hmm it does make sense, and it's not too late to fix this up. Jason, what's your take on this? Was
_IOWintentional?My bad, not intentional. And I agree that fixing this is not too late.
So
Acked-by Jason Wang <[email protected]>
OK then
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
--- include/uapi/linux/vhost.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/uapi/linux/vhost.h +1
-1@@ -176,7 +176,7 @@ struct vhost_memory {#define VHOST_BACKEND_F_IOTLB_MSG_V2 0x1#define VHOST_SET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x25, __u64) -#define VHOST_GET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x26, __u64) +#define VHOST_GET_BACKEND_FEATURES _IOR(VHOST_VIRTIO, 0x26, __u64)/* VHOST_NET specific defines */
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
include/uapi/linux/vhost.h +0
-1--glebfm
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
From: "Michael S. Tsirkin" <[email protected]>
Date: Mon, 3 Sep 2018 23:11:11 -0400
Quoted 16 lines · Jason Wang
Quoted 15 lines · Michael S. Tsirkin
Quoted 9 lines · Gleb Fotengauer-Malinovskiy
Quoted 6 lines
The
_IOC_READflag fits this ioctl request more because this request actually only writes to, but doesn't read from userspace. See NOTEs ininclude/uapi/asm-generic/ioctl.hfor more information.Fixes 429711aec282 ("vhost: switch to use new message format")Signed-off-by Gleb Fotengauer-Malinovskiy <[email protected]>Hmm it does make sense, and it's not too late to fix this up. Jason, what's your take on this? Was
_IOWintentional?My bad, not intentional. And I agree that fixing this is not too late.
Quoted 8 lines
Quoted 3 lines
So
Acked-by Jason Wang <[email protected]>OK then
Applied, thanks everyone.
From: "Michael S. Tsirkin" <[email protected]>
Date: Mon, 3 Sep 2018 23:11:11 -0400
Quoted 16 lines · Jason Wang
Quoted 15 lines · Michael S. Tsirkin
Quoted 9 lines · Gleb Fotengauer-Malinovskiy
Quoted 6 lines
The
_IOC_READflag fits this ioctl request more because this request actually only writes to, but doesn't read from userspace. See NOTEs ininclude/uapi/asm-generic/ioctl.hfor more information.Fixes 429711aec282 ("vhost: switch to use new message format")Signed-off-by Gleb Fotengauer-Malinovskiy <[email protected]>Hmm it does make sense, and it's not too late to fix this up. Jason, what's your take on this? Was
_IOWintentional?My bad, not intentional. And I agree that fixing this is not too late.
Quoted 8 lines
Quoted 3 lines
So
Acked-by Jason Wang <[email protected]>OK then
Applied, thanks everyone.