can: mcp251x: fix fall-through annotation

PATCH New Gustavo A. R. Silva 1 participant 1 message Sep 3, 2018

Subsystems (3)

Networking Network drivers CAN network drivers

lore

Share & tools

lore

Gustavo A. R. Silva

author

2018-09-03 18:25 UTC #0 lore raw

PATCH 1/1 can: mcp251x: fix fall-through annotation

Properly place the "fall through" annotation at the bottom of the case, which is what GCC is expecting to find.

This fix is part of the ongoing efforts to enabling -Wimplicit-fallthrough

Addresses-Coverity-ID: 114880 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/net/can/spi/mcp251x.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

drivers/net/can/spi/mcp251x.c +2 -1

index e908176..17257c7 100644
@@ -875,7 +875,8 @@ static irqreturn_t mcp251x_can_ist(int irq, void *dev_id)
 			if (new_state >= CAN_STATE_ERROR_WARNING &&
 			    new_state <= CAN_STATE_BUS_OFF)
 				priv->can.can_stats.error_warning++;
-		case CAN_STATE_ERROR_WARNING:	/* fallthrough */
+			/* fall through */
+		case CAN_STATE_ERROR_WARNING:
 			if (new_state >= CAN_STATE_ERROR_PASSIVE &&
 			    new_state <= CAN_STATE_BUS_OFF)
 				priv->can.can_stats.error_passive++;

Signature · 1 line

2.7.4