usb: typec: ucsi: add support for Cypress CCGx
Greg Kroah-Hartman
maintainerPATCH v5 2/2 usb: typec: ucsi: add support for Cypress CCGx
Review
Quoted 3 lines · Ajay Gupta
(quoted diff) +3
-0+ dev_info(dev, "Silicon id %2ph", data + CCGX_I2C_RAB_READ_SILICON_ID); + dev_info(dev, "FW1 version %8ph\n", data + CCGX_I2C_RAB_FW1_VERSION); + dev_info(dev, "FW2 version %8ph\n", data + CCGX_I2C_RAB_FW2_VERSION);
Drivers should be totally quiet when initialized, unless something goes wrong. Please don't spam the kernel log with this type of stuff.
You can use dev_dbg() if it helps with debugging the code, that might be a better idea here.
Also, a pointer? Are you sure about that? That looks really odd...
thanks,
greg k-h