Skip to contentSkip to conversation

drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax (v2)

PATCH New [email protected] 2 participants 4 messages Sep 7, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax (v2)

From: Kai Chen <[email protected]>

On GEN9LP, raise the RPS FUp Interrupt Limiter above softmax so that the HW won't miss interrupt when requested max_freq is set back to RP0 value.
The (v2) is to explain a bit more detail background about the change in the code.

---
 drivers/gpu/drm/i915/intel_pm.c | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_pm.c +21 -1
index d99e5fabe93c..6574696b83cb 100644
@@ -6276,7 +6276,27 @@ static u32 intel_rps_limits(struct drm_i915_private *dev_priv, u8 val)
 	 * frequency, if the down threshold expires in that window we will not
 	 * receive a down interrupt. */
 	if (INTEL_GEN(dev_priv) >= 9) {
-		limits = (rps->max_freq_softlimit) << 23;
+		int max_freq = rps->max_freq_softlimit;
+		int rp0_freq = rps->rp0_freq;
+
+		if (IS_GEN9_LP(dev_priv) && (max_freq == rp0_freq))
+			/* For GEN9_LP, the HW seems insensitive to the RP FUp
+			 * interrupt limiter threshold by design. This symptom
+			 * is experienced in the IGT test (pm_rps): when the
+			 * test sets the max_freq back to RP0, the interrupt
+			 * limits register is also programmed to the max_freq
+			 * per design. But as a result, the actual freq is not
+			 * the max_freq detected. It is suggested (based on the
+			 * best test/tuning practice) to increase the upper
+			 * interrupt limiter just by 1 (16.6MHz) so that the HW
+			 * will generate an interrupt when we are near or just
+			 * below the upper limit.
+			 */
+
+			limits = (rps->max_freq_softlimit + 1) << 23;
+		else
+			limits = (rps->max_freq_softlimit) << 23;
+
 		if (val <= rps->min_freq_softlimit)
 			limits |= (rps->min_freq_softlimit) << 14;
 	} else {
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax (rev2)

== Series Details ==

== Series Details ==

Series: drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax (rev2)
URL : https://patchwork.freedesktop.org/series/49293/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
c6c96482c96e drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax (v2)
-:27: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'max_freq == rp0_freq'
#27: FILE: drivers/gpu/drm/i915/intel_pm.c:6282:
+		if (IS_GEN9_LP(dev_priv) && (max_freq == rp0_freq))

total: 0 errors, 0 warnings, 1 checks, 28 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✓ Fi.CI.BAT: success for drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax (rev2)

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax (rev2)
URL : https://patchwork.freedesktop.org/series/49293/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4782 -> Patchwork_10117 =

== Summary - SUCCESS ==

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/49293/revisions/2/mbox/

== Known issues ==

Here are the changes found in Patchwork_10117 that come from known issues:

=== IGT changes ===

    ==== Possible fixes ====

    igt@amdgpu/amd_cs_nop@sync-fork-gfx0:
      fi-kbl-8809g:       DMESG-WARN (fdo#107762) -> PASS

    igt@kms_psr@primary_page_flip:
      fi-kbl-7560u:       FAIL (fdo#107336) -> PASS

    
    ==== Warnings ====

    igt@amdgpu/amd_prime@amd-to-i915:
      fi-kbl-8809g:       DMESG-FAIL (fdo#107762) -> FAIL (fdo#107341)

fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
fdo#107341 https://bugs.freedesktop.org/show_bug.cgi?id=107341
fdo#107762 https://bugs.freedesktop.org/show_bug.cgi?id=107762

== Participating hosts (52 -> 49) ==

Additional (2): fi-byt-j1900 fi-gdg-551
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u

== Build changes ==

* Linux: CI_DRM_4782 -> Patchwork_10117

CI_DRM_4782: 60edf94611d2374821fbe2a824cebcb425ce7b0d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4632: 94b4e204473a7d9f49e536c8877a4a5636e0d1b2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10117: c6c96482c96efd6e9503fc6a83f3d8e9b5a7c2f9 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

c6c96482c96e drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax (v2)

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10117/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

✓ Fi.CI.IGT: success for drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax (rev2)

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: drm/i915: Raise RPS FUp Interrupt Limiter for GEN9LP above softmax (rev2)
URL : https://patchwork.freedesktop.org/series/49293/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4782_full -> Patchwork_10117_full =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_10117_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10117_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_10117_full:

=== IGT changes ===

    ==== Warnings ====

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
      shard-snb:          INCOMPLETE (fdo#105411) -> DMESG-FAIL

== Known issues ==

Here are the changes found in Patchwork_10117_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@kms_frontbuffer_tracking@fbcpsr-stridechange:
      shard-snb:          NOTRUN -> INCOMPLETE (fdo#105411)

    
    ==== Possible fixes ====

    igt@drv_suspend@shrink:
      shard-snb:          INCOMPLETE (fdo#106886, fdo#105411) -> PASS
      shard-glk:          FAIL (fdo#106886) -> PASS

    igt@gem_eio@in-flight-suspend:
      shard-kbl:          INCOMPLETE (fdo#103665, fdo#106702) -> PASS

    igt@kms_setmode@basic:
      shard-apl:          FAIL (fdo#99912) -> PASS

fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#106702 https://bugs.freedesktop.org/show_bug.cgi?id=106702
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912

== Participating hosts (5 -> 5) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_4782 -> Patchwork_10117

CI_DRM_4782: 60edf94611d2374821fbe2a824cebcb425ce7b0d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4632: 94b4e204473a7d9f49e536c8877a4a5636e0d1b2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10117: c6c96482c96efd6e9503fc6a83f3d8e9b5a7c2f9 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10117/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx