Skip to contentSkip to conversation

drm/i915: fix SPDX license identifiers

PATCH In review Jani Nikula 4 participants 5 messages Sep 7, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: fix SPDX license identifiers

Commit b24413180f56 ("License cleanup: add SPDX GPL-2.0 license identifier to files with no license") added default GPL-2.0 identifiers to i915 files without a license. For i915 the right choice would have been MIT. Fix it.

Fixes b24413180f56 ("License cleanup: add SPDX GPL-2.0 license identifier to files with no license")
Cc Joonas Lahtinen <[email protected]>
Cc Rodrigo Vivi <[email protected]>
---
 drivers/gpu/drm/i915/i915_trace.h        | 2 +-
 drivers/gpu/drm/i915/i915_trace_points.c | 2 +-
 drivers/gpu/drm/i915/intel_acpi.c        | 2 +-
 drivers/gpu/drm/i915/intel_ringbuffer.h  | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_trace.h +1 -1
index b50c6b829715..a3952af63503 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: MIT */
 #if !defined(_I915_TRACE_H_) || defined(TRACE_HEADER_MULTI_READ)
 #define _I915_TRACE_H_
 
drivers/gpu/drm/i915/i915_trace_points.c +1 -1
index 463a7177997c..15891addec93 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: MIT
 /*
  * Copyright © 2009 Intel Corporation
  *
drivers/gpu/drm/i915/intel_acpi.c +1 -1
index 6ba478e57b9b..5de5131884e1 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: MIT
 /*
  * Intel ACPI functions
  *
drivers/gpu/drm/i915/intel_ringbuffer.h +1 -1
index 3f6920dd7880..50ce94a0f31c 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: MIT */
 #ifndef _INTEL_RINGBUFFER_H_
 #define _INTEL_RINGBUFFER_H_
 
Signature · 6 lines
2.11.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

Quoting Jani Nikula (2018-09-07 08:08:21)

Quoted 31 lines

Commit b24413180f56 ("License cleanup: add SPDX GPL-2.0 license identifier to files with no license") added default GPL-2.0 identifiers to i915 files without a license. For i915 the right choice would have been MIT. Fix it.

Fixes b24413180f56 ("License cleanup: add SPDX GPL-2.0 license identifier to files with no license")
Cc Joonas Lahtinen <[email protected]>
Cc Rodrigo Vivi <[email protected]>
---
 drivers/gpu/drm/i915/i915_trace.h        | 2 +-
 drivers/gpu/drm/i915/i915_trace_points.c | 2 +-
 drivers/gpu/drm/i915/intel_acpi.c        | 2 +-
 drivers/gpu/drm/i915/intel_ringbuffer.h  | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_trace.h +1 -1
index b50c6b829715..a3952af63503 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: MIT */
 #if !defined(_I915_TRACE_H_) || defined(TRACE_HEADER_MULTI_READ)
 #define _I915_TRACE_H_
 
drivers/gpu/drm/i915/i915_trace_points.c +0 -0
index 463a7177997c..15891addec93 100644

drivers/gpu/drm/i915/i915_trace_points.c line 1

Quoted 2 lines
drivers/gpu/drm/i915/i915_trace_points.c +1 -1
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: MIT

I think strictly the tracepoint code has to be at least GPL-2.0 as it includes mechanism that is GPL-2.0.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Jani Nikula
Quoted 9 lines · Jani Nikula

Commit b24413180f56 ("License cleanup: add SPDX GPL-2.0 license identifier to files with no license") added default GPL-2.0 identifiers to i915 files without a license. For i915 the right choice would have been MIT. Fix it.

Fixes b24413180f56 ("License cleanup: add SPDX GPL-2.0 license identifier to files with no license")
Cc Joonas Lahtinen <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Quoted 50 lines
---
 drivers/gpu/drm/i915/i915_trace.h        | 2 +-
 drivers/gpu/drm/i915/i915_trace_points.c | 2 +-
 drivers/gpu/drm/i915/intel_acpi.c        | 2 +-
 drivers/gpu/drm/i915/intel_ringbuffer.h  | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_trace.h +1 -1
index b50c6b829715..a3952af63503 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: MIT */
 #if !defined(_I915_TRACE_H_) || defined(TRACE_HEADER_MULTI_READ)
 #define _I915_TRACE_H_
 
drivers/gpu/drm/i915/i915_trace_points.c +1 -1
index 463a7177997c..15891addec93 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: MIT
 /*
  * Copyright © 2009 Intel Corporation
  *
drivers/gpu/drm/i915/intel_acpi.c +1 -1
index 6ba478e57b9b..5de5131884e1 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: MIT
 /*
  * Intel ACPI functions
  *
drivers/gpu/drm/i915/intel_ringbuffer.h +1 -1
index 3f6920dd7880..50ce94a0f31c 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: MIT */
 #ifndef _INTEL_RINGBUFFER_H_
 #define _INTEL_RINGBUFFER_H_
 
Signature · 1 line
2.11.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

✓ Fi.CI.BAT: success for drm/i915: fix SPDX license identifiers

In reply to Jani Nikula
== Series Details ==

== Series Details ==

Series: drm/i915: fix SPDX license identifiers
URL : https://patchwork.freedesktop.org/series/49323/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4785 -> Patchwork_10121 =

== Summary - SUCCESS ==

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/49323/revisions/1/mbox/

== Known issues ==

Here are the changes found in Patchwork_10121 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_hangcheck:
      fi-skl-guc:         PASS -> DMESG-FAIL (fdo#107174, fdo#106685)

    igt@gem_exec_suspend@basic-s3:
      fi-byt-clapper:     PASS -> INCOMPLETE (fdo#102657)

    
    ==== Possible fixes ====

    igt@gem_exec_suspend@basic-s4-devices:
      fi-kbl-7500u:       DMESG-WARN (fdo#107139, fdo#105128) -> PASS

fdo#102657 https://bugs.freedesktop.org/show_bug.cgi?id=102657
fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
fdo#106685 https://bugs.freedesktop.org/show_bug.cgi?id=106685
fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139
fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174

== Participating hosts (53 -> 46) ==

Missing (7): fi-hsw-4770r fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-icl-u

== Build changes ==

* Linux: CI_DRM_4785 -> Patchwork_10121

CI_DRM_4785: 7fddb79b0908d5c08efc93656fd10a761c9d14ca @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4634: 7d89cc39dde3b4881d85ace45d504cc098fa3684 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10121: 29f97d1e330a50fe69b84f9dd9fda41da9348cea @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

29f97d1e330a drm/i915: fix SPDX license identifiers

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10121/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

✓ Fi.CI.IGT: success for drm/i915: fix SPDX license identifiers

In reply to Jani Nikula
== Series Details ==

== Series Details ==

Series: drm/i915: fix SPDX license identifiers
URL : https://patchwork.freedesktop.org/series/49323/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4785_full -> Patchwork_10121_full =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_10121_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10121_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_10121_full:

=== IGT changes ===

    ==== Warnings ====

    igt@perf_pmu@rc6:
      shard-kbl:          SKIP -> PASS

== Known issues ==

Here are the changes found in Patchwork_10121_full that come from known issues:

=== IGT changes ===

    ==== Possible fixes ====

    igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
      shard-glk:          FAIL (fdo#107409, fdo#106509) -> PASS

    igt@kms_flip@flip-vs-expired-vblank-interruptible:
      shard-glk:          FAIL (fdo#102887, fdo#105363) -> PASS

    igt@perf@polling:
      shard-hsw:          FAIL (fdo#102252) -> PASS

fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#107409 https://bugs.freedesktop.org/show_bug.cgi?id=107409

== Participating hosts (5 -> 5) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_4785 -> Patchwork_10121

CI_DRM_4785: 7fddb79b0908d5c08efc93656fd10a761c9d14ca @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4634: 7d89cc39dde3b4881d85ace45d504cc098fa3684 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10121: 29f97d1e330a50fe69b84f9dd9fda41da9348cea @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10121/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx