Skip to contentSkip to conversation

nvif: allow userspace to use the notification interfaces

PATCH New Karol Herbst 1 participant 2 messages Sep 8, 2018 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 nvif: allow userspace to use the notification interfaces

we need those so that userspace can get notified about channel resets. Required to implement GL_ARB_robustness correctly. Currently we advertise it, but we aren't able to handle gpu resets inside mesa without it.

---
 drm/nouveau/nouveau_abi16.c | 4 ++++
 1 file changed, 4 insertions(+)
drm/nouveau/nouveau_abi16.c +4 -0
index e67a4713..249b00ae 100644
@@ -383,6 +383,10 @@ nouveau_abi16_usif(struct drm_file *file_priv, void *data, u32 size)
 		case NVIF_IOCTL_V0_NEW:
 		case NVIF_IOCTL_V0_MTHD:
 		case NVIF_IOCTL_V0_SCLASS:
+		case NVIF_IOCTL_V0_NTFY_NEW:
+		case NVIF_IOCTL_V0_NTFY_DEL:
+		case NVIF_IOCTL_V0_NTFY_GET:
+		case NVIF_IOCTL_V0_NTFY_PUT:
 			break;
 		default:
 			return -EACCES;
Signature · 6 lines
2.17.1

_______________________________________________
Nouveau mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/nouveau

A message that is not in the archive (sent off-list or not yet received): 20180908230320.7887-1-kherbst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org

#2 lore raw

PATCH 2/2 usif: use correct struct inside usif_notify_get

No functional change, but this is clearly a copy and paste error.

---
 drm/nouveau/nouveau_usif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drm/nouveau/nouveau_usif.c +1 -1
index 9dc10b17..34d48775 100644
@@ -192,7 +192,7 @@ usif_notify_get(struct drm_file *f, void *data, u32 size, void *argv, u32 argc)
 	struct nouveau_cli *cli = nouveau_cli(f);
 	struct nvif_client *client = &cli->base;
 	union {
-		struct nvif_ioctl_ntfy_del_v0 v0;
+		struct nvif_ioctl_ntfy_get_v0 v0;
 	} *args = data;
 	struct usif_notify *ntfy;
 	int ret = -ENOSYS;
Signature · 6 lines
2.17.1

_______________________________________________
Nouveau mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/nouveau