Skip to contentSkip to conversation

libgloss_3.0.0.bb: Fix up mv pattern to include libnosys

PATCH In review Nathan Rossi 2 participants 4 messages Sep 10, 2018 – Sep 13, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libgloss_3.0.0.bb: Fix up mv pattern to include libnosys

When installing libgloss libraries handle the ${TARGET_SYS}/lib contents so that it is placed in ${libdir} instead of ${libdir}/lib. This resolves a packaging QA issue.

ERROR: libgloss-3.0.0-r0 do_package: QA Issue: libgloss:
Files/directories were installed but not shipped in any package:
/usr/lib/lib
/usr/lib/lib/libnosys.a
/usr/lib/lib/nosys.specs
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
libgloss: 3 installed and not shipped files. [installed-vs-shipped]

---
 meta/recipes-core/newlib/libgloss_3.0.0.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-core/newlib/libgloss_3.0.0.bb +2 -1
index 664a922815..727062ca5d 100644
@@ -18,9 +18,10 @@ do_install_prepend() {
 
 do_install_append() {
 	# Move libs to default directories so they can be picked up later
-	mv -v ${D}${prefix}/${TARGET_SYS}/lib ${D}${libdir}
+	mv -v ${D}${prefix}/${TARGET_SYS}/lib/* ${D}${libdir}
 
 	# Remove original directory
+	rmdir ${D}${prefix}/${TARGET_SYS}/lib
 	rmdir ${D}${prefix}/${TARGET_SYS}
 }
 

---
2.18.0

#1 lore raw
Quoted 25 lines · Nathan Rossi

When installing libgloss libraries handle the ${TARGET_SYS}/lib contents so that it is placed in ${libdir} instead of ${libdir}/lib. This resolves a packaging QA issue.

ERROR: libgloss-3.0.0-r0 do_package: QA Issue: libgloss:
Files/directories were installed but not shipped in any package:
/usr/lib/lib
/usr/lib/lib/libnosys.a
/usr/lib/lib/nosys.specs
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
libgloss: 3 installed and not shipped files. [installed-vs-shipped]

---
 meta/recipes-core/newlib/libgloss_3.0.0.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-core/newlib/libgloss_3.0.0.bb +0 -0
index 664a922815..727062ca5d 100644

meta/recipes-core/newlib/libgloss_3.0.0.bb do_install_prepend() { · line 21

Quoted 5 lines
meta/recipes-core/newlib/libgloss_3.0.0.bb +1 -1
@@ -18,9 +18,10 @@ do_install_prepend() {
 
 do_install_append() {
        # Move libs to default directories so they can be picked up later
-       mv -v ${D}${prefix}/${TARGET_SYS}/lib ${D}${libdir}
+       mv -v ${D}${prefix}/${TARGET_SYS}/lib/* ${D}${libdir}

seems to some indentation problem, please check.

meta/recipes-core/newlib/libgloss_3.0.0.bb do_install_prepend() { · line 24

Quoted 3 lines
meta/recipes-core/newlib/libgloss_3.0.0.bb +1 -0
        # Remove original directory
+       rmdir ${D}${prefix}/${TARGET_SYS}/lib

maybe just use -p option above and remove the statement below

Quoted 10 lines
meta/recipes-core/newlib/libgloss_3.0.0.bb +0 -1
        rmdir ${D}${prefix}/${TARGET_SYS}
 }
 
---

2.18.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#2 lore raw
Quoted 28 lines · Khem Raj
Quoted 26 lines · Nathan Rossi

When installing libgloss libraries handle the ${TARGET_SYS}/lib contents so that it is placed in ${libdir} instead of ${libdir}/lib. This resolves a packaging QA issue.

ERROR: libgloss-3.0.0-r0 do_package: QA Issue: libgloss:
Files/directories were installed but not shipped in any package:
/usr/lib/lib
/usr/lib/lib/libnosys.a
/usr/lib/lib/nosys.specs
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
libgloss: 3 installed and not shipped files. [installed-vs-shipped]

---
 meta/recipes-core/newlib/libgloss_3.0.0.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-core/newlib/libgloss_3.0.0.bb +0 -0
index 664a922815..727062ca5d 100644
@@ -18,9 +18,10 @@ do_install_prepend() {
 
Quoted 6 lines

meta/recipes-core/newlib/libgloss_3.0.0.bb do_install_prepend() { · line 21

Quoted 4 lines
meta/recipes-core/newlib/libgloss_3.0.0.bb +1 -1
 do_install_append() {
        # Move libs to default directories so they can be picked up later
-       mv -v ${D}${prefix}/${TARGET_SYS}/lib ${D}${libdir}
+       mv -v ${D}${prefix}/${TARGET_SYS}/lib/* ${D}${libdir}

seems to some indentation problem, please check.

Hmm, its all tabs (which is what the rest of the file is) and git-am seems to apply without issues. What am I missing?

Quoted 6 lines

meta/recipes-core/newlib/libgloss_3.0.0.bb do_install_prepend() { · line 24

Quoted 4 lines
meta/recipes-core/newlib/libgloss_3.0.0.bb +1 -0
        # Remove original directory
+       rmdir ${D}${prefix}/${TARGET_SYS}/lib

maybe just use -p option above and remove the statement below

It looks like this patch was already merged into master. Should I send another patch to change it to rmdir -p --ignore-fail-on-non-empty?

Thanks,
Nathan

Quoted 11 lines
Quoted 11 lines
meta/recipes-core/newlib/libgloss_3.0.0.bb +0 -1
        rmdir ${D}${prefix}/${TARGET_SYS}
 }
 
---

2.18.0
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#3 lore raw
Quoted 37 lines · Nathan Rossi
Quoted 28 lines · Khem Raj
Quoted 26 lines · Nathan Rossi

When installing libgloss libraries handle the ${TARGET_SYS}/lib contents so that it is placed in ${libdir} instead of ${libdir}/lib. This resolves a packaging QA issue.

ERROR: libgloss-3.0.0-r0 do_package: QA Issue: libgloss:
Files/directories were installed but not shipped in any package:
/usr/lib/lib
/usr/lib/lib/libnosys.a
/usr/lib/lib/nosys.specs
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
libgloss: 3 installed and not shipped files. [installed-vs-shipped]

---
 meta/recipes-core/newlib/libgloss_3.0.0.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-core/newlib/libgloss_3.0.0.bb +0 -0
index 664a922815..727062ca5d 100644
@@ -18,9 +18,10 @@ do_install_prepend() {
 
Quoted 6 lines

meta/recipes-core/newlib/libgloss_3.0.0.bb do_install_prepend() { · line 21

Quoted 4 lines
meta/recipes-core/newlib/libgloss_3.0.0.bb +1 -1
 do_install_append() {
        # Move libs to default directories so they can be picked up later
-       mv -v ${D}${prefix}/${TARGET_SYS}/lib ${D}${libdir}
+       mv -v ${D}${prefix}/${TARGET_SYS}/lib/* ${D}${libdir}

seems to some indentation problem, please check.

Quoted 2 lines

Hmm, its all tabs (which is what the rest of the file is) and git-am seems to apply without issues. What am I missing?

perhaps if you can.