Skip to contentSkip to conversation

mfd: omap-usb-host: Use regular platform device probe mechanism

PATCH New Tony Lindgren 1 participant 1 message Sep 11, 2018 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 mfd: omap-usb-host: Use regular platform device probe mechanism

drivers/mfd/omap-usb-host.c static struct platform_driver usbhs_omap_driver = { · line 861

Quoted 9 lines · Laurent Pinchart
drivers/mfd/omap-usb-host.c +1 -0
@@ -855,31 +856,14 @@ static struct platform_driver usbhs_omap_driver = {
 		.pm		= &usbhsomap_dev_pm_ops,
 		.of_match_table = usbhs_omap_dt_ids,
 	},
+	.probe		= usbhs_omap_probe,
 	.remove		= usbhs_omap_remove,
 };

So I have this already along few other fixes in patch "[PATCH] mfd: omap-usb-host: Fix dts probe of children".

Quoted 17 lines
drivers/mfd/omap-usb-host.c +2 -10
+module_platform_driver(usbhs_omap_driver);
+
 MODULE_AUTHOR("Keshava Munegowda <[email protected]>");
 MODULE_AUTHOR("Roger Quadros <[email protected]>");
 MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("usb host common core driver for omap EHCI and OHCI");
-
-static int __init omap_usbhs_drvinit(void)
-{
-	return platform_driver_probe(&usbhs_omap_driver, usbhs_omap_probe);
-}
-
-/*
- * init before ehci and ohci drivers;
- * The usbhs core driver should be initialized much before
- * the omap ehci and ohci probe functions are called.

drivers/mfd/omap-usb-host.c static struct platform_driver usbhs_omap_driver = { · line 884

Quoted 10 lines
drivers/mfd/omap-usb-host.c +0 -10
- * This usbhs core driver should be initialized after
- * usb tll driver
- */
-fs_initcall_sync(omap_usbhs_drvinit);
-
-static void __exit omap_usbhs_drvexit(void)
-{
-	platform_driver_unregister(&usbhs_omap_driver);
-}
-module_exit(omap_usbhs_drvexit);

Seems like part can then become part of your clean-up for v4.20 then?

Regards,

Tony