net/appletalk: fix minor pointer leak to userspace in SIOCFINDIPDDPRT
Subsystems (2)
PATCH 1/1 net/appletalk: fix minor pointer leak to userspace in SIOCFINDIPDDPRT
Fields ->dev and ->next of struct ipddp_route may be copied to userspace on the SIOCFINDIPDDPRT ioctl. This is only accessible to CAP_NET_ADMIN though. Let's manually copy the relevant fields instead of using memcpy().
Cc Jann Horn <[email protected]>
Signed-off-by Willy Tarreau <[email protected]>
--- drivers/net/appletalk/ipddp.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/net/appletalk/ipddp.c +6 -2
@@ -283,8 +283,12 @@ static int ipddp_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)case SIOCFINDIPDDPRT :spin_lock_bh (&ipddp_route_lock); rp =__ipddp_find_route (&rcp); -if (rp) -memcpy (&rcp2, rp,sizeof (rcp2)); +if (rp) { +memset (&rcp2,0 ,sizeof (rcp2)); + rcp2.ip = rp->ip; + rcp2.at = rp->at; + rcp2.flags = rp->flags; + }spin_unlock_bh (&ipddp_route_lock);if (rp) {
Signature · 1 line
2.8.0.rc2.1.gbe9624a