Skip to contentSkip to conversation

request for 4.4-stable: 5817f977527e ("ethernet: ti: davinci_emac: add missing of_node_put after calling of_parse_phandle")

PATCH SZ Lin (林上智) 2 participants 2 messages Sep 12, 2018 – Sep 17, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hi Greg,

This patch is not marked for 4.4-stable, but it's already in 4.9 and 4.14 stable.

Please apply to 4.4-stable.

This patch adds necessary function when removing driver.

--
SZ Lin (林上智)

Quoted 1 line

From 3ace61154f92cfbc516ee178378af48f2d6596b2 Mon Sep 17 00:00:00 2001

From: Peter Chen <[email protected]>
Date: Mon, 1 Aug 2016 15:02:43 +0800
Subject: [PATCH] ethernet: ti: davinci_emac: add missing of_node_put after
calling of_parse_phandle

commit 5817f977527e5cdbea9ca56d2b95824f59c8747d upstream

of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using.

---
 drivers/net/ethernet/ti/davinci_emac.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/ti/davinci_emac.c +1 -0
index 6be315303d61..8ecb24186b7f 100644
@@ -2108,6 +2108,7 @@ static int davinci_emac_remove(struct platform_device *pdev)
 	cpdma_ctlr_destroy(priv->dma);
 
 	unregister_netdev(ndev);
+	of_node_put(priv->phy_node);
 	free_netdev(ndev);
 
 	return 0;
Signature · 1 line
2.19.0
#1 lore raw
Quoted 7 lines · SZ Lin (林上智)

Hi Greg,

This patch is not marked for 4.4-stable, but it's already in 4.9 and 4.14 stable.

Please apply to 4.4-stable.

This patch adds necessary function when removing driver.

Now applied, thanks.

greg k-h