Skip to contentSkip to conversation

linux-libc-headers: Don't do useless configuration

PATCH New Alexey Brodkin 1 participant 1 message Sep 12, 2018

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 linux-libc-headers: Don't do useless configuration

There's no point in configuring Linux kernel before headers installation.

Moreover in come cases it might lead to problems on kernels starting from 4.17 with architecture or platfrom sets CROSS_COMPILE variable automatically, see [1].

Also note Buildroot doesn't do that kind of confiuration as well, see [2].

And while at it convert empty do_compile to noexec as well.

[1] https://lkml.org/lkml/2018/9/12/486
[2] https://git.buildroot.org/buildroot/tree/package/linux-headers/linux-headers.mk#n106

---

Changes v1 -> v2:
* Use noexec approach for do_configure
* Convert do_compile to noexec as well

 .../linux-libc-headers/linux-libc-headers.inc              | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc +2 -5
index 05c82558e653..be215af9b953 100644
@@ -53,12 +53,9 @@ S = "${WORKDIR}/linux-${PV}"
 
 EXTRA_OEMAKE = " HOSTCC="${BUILD_CC}" HOSTCPP="${BUILD_CPP}""
 
-do_configure() {
-	oe_runmake allnoconfig
-}
+do_configure[noexec] = "1"
 
-do_compile () {
-}
+do_compile[noexec] = "1"
 
 do_install() {
 	oe_runmake headers_install INSTALL_HDR_PATH=${D}${exec_prefix}
Signature · 1 line
2.17.1