Skip to contentSkip to conversation

ARM: dts: stm32: Fix SPI controller node names

PATCH New Rob Herring 2 participants 4 messages Sep 13, 2018 – Sep 21, 2018

Subsystems (2)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 ARM: dts: stm32: Fix SPI controller node names

SPI controller nodes should be named 'spi' rather than 'ssp'. Fixing the name enables dtc SPI bus checks.

Cc Maxime Coquelin <[email protected]>
Cc Alexandre Torgue <[email protected]>

---
Please apply to the sub-arch tree. The dtc changes haven't landed, but will for 4.20.

 arch/arm/boot/dts/stm32mp157c.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/stm32mp157c.dtsi +1 -1
index 661be948ab74..0e5a2f89f2d9 100644
@@ -947,7 +947,7 @@
 			dma-requests = <48>;
 		};
 
-		qspi: qspi at 58003000 {
+		qspi: spi at 58003000 {
 			compatible = "st,stm32f469-qspi";
 			reg = <0x58003000 0x1000>, <0x70000000 0x10000000>;
 			reg-names = "qspi", "qspi_mm";
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 ARM: dts: stm32: Fix SPI controller node names

Quoted 9 lines · Rob Herring

SPI controller nodes should be named 'spi' rather than 'ssp'. Fixing the name enables dtc SPI bus checks.

Cc Maxime Coquelin <[email protected]>
Cc Alexandre Torgue <[email protected]>

---
Please apply to the sub-arch tree. The dtc changes haven't landed, but will for 4.20.

Thanks Rob. I will add it in my next PR for 4.20.

Quoted 18 lines
  arch/arm/boot/dts/stm32mp157c.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/stm32mp157c.dtsi +1 -1
index 661be948ab74..0e5a2f89f2d9 100644
@@ -947,7 +947,7 @@
  			dma-requests = <48>;
  		};
 
-		qspi: qspi at 58003000 {
+		qspi: spi at 58003000 {
  			compatible = "st,stm32f469-qspi";
  			reg = <0x58003000 0x1000>, <0x70000000 0x10000000>;
  			reg-names = "qspi", "qspi_mm";
#2 lore raw

PATCH 1/1 ARM: dts: stm32: Fix SPI controller node names

In reply to Rob Herring

Hi Rob

Quoted 1 line · Rob Herring

SPI controller nodes should be named 'spi' rather than 'ssp'. Fixing the

I assume that you meant "SPI controller nodes should be named 'spi' rather than 'qspi'" (not ssp). I'll update commit message when I'll merge if you confirm.

regards
Alex

Quoted 26 lines

name enables dtc SPI bus checks.

Cc Maxime Coquelin <[email protected]>
Cc Alexandre Torgue <[email protected]>

---
Please apply to the sub-arch tree. The dtc changes haven't landed, but will for 4.20.

  arch/arm/boot/dts/stm32mp157c.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/stm32mp157c.dtsi +1 -1
index 661be948ab74..0e5a2f89f2d9 100644
@@ -947,7 +947,7 @@
  			dma-requests = <48>;
  		};
 
-		qspi: qspi at 58003000 {
+		qspi: spi at 58003000 {
  			compatible = "st,stm32f469-qspi";
  			reg = <0x58003000 0x1000>, <0x70000000 0x10000000>;
  			reg-names = "qspi", "qspi_mm";
#3 lore raw

PATCH 1/1 ARM: dts: stm32: Fix SPI controller node names

In reply to Rob Herring

Hi Rob

Quoted 19 lines · Rob Herring

SPI controller nodes should be named 'spi' rather than 'ssp'. Fixing the name enables dtc SPI bus checks.

Cc Maxime Coquelin <[email protected]>
Cc Alexandre Torgue <[email protected]>

---
Please apply to the sub-arch tree. The dtc changes haven't landed, but will for 4.20.

  arch/arm/boot/dts/stm32mp157c.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/stm32mp157c.dtsi +0 -0
index 661be948ab74..0e5a2f89f2d9 100644

arch/arm/boot/dts/stm32mp157c.dtsi line 953

Quoted 8 lines
arch/arm/boot/dts/stm32mp157c.dtsi +1 -1
@@ -947,7 +947,7 @@
  			dma-requests = <48>;
  		};
 
-		qspi: qspi at 58003000 {
+		qspi: spi at 58003000 {
  			compatible = "st,stm32f469-qspi";
  			reg = <0x58003000 0x1000>, <0x70000000 0x10000000>;
  			reg-names = "qspi", "qspi_mm";

After fixup commmit message:

Applied on stm32-next.

Thanks.
Alex