Skip to contentSkip to conversation

arm64: dts: broadcom: Fix I2C and SPI bus warnings

PATCH New Rob Herring 3 participants 3 messages Sep 13, 2018

Subsystems (2)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 arm64: dts: broadcom: Fix I2C and SPI bus warnings

dtc has new checks for I2C and SPI buses. Fix the warnings in node names and unit-addresses.

arch/arm64/boot/dts/broadcom/stingray/bcm958742k.dtb: Warning (i2c_bus_reg): /hsls/i2c at e0000/pcf8574 at 20: I2C bus unit address format error, expected "27" arch/arm64/boot/dts/broadcom/stingray/bcm958742t.dtb: Warning (i2c_bus_reg): /hsls/i2c at e0000/pcf8574 at 20: I2C bus unit address format error, expected "27" arch/arm64/boot/dts/broadcom/stingray/bcm958742k.dtb: Warning (spi_bus_bridge): /hsls/ssp at 180000: node name for SPI buses should be 'spi' arch/arm64/boot/dts/broadcom/stingray/bcm958742k.dtb: Warning (spi_bus_bridge): /hsls/ssp at 190000: node name for SPI buses should be 'spi'

Cc Ray Jui <[email protected]>
Cc Scott Branden <[email protected]>
Cc Jon Mason <[email protected]>
Cc bcm-kernel-feedback-list at broadcom.com

---
Please apply to the sub-arch tree. The dtc changes haven't landed, but will for 4.20.

 arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi          | 4 ++--
 arch/arm64/boot/dts/broadcom/stingray/bcm958742-base.dtsi | 2 +-
 arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi       | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi +2 -2
index 1a406a76c86a..ea854f689fda 100644
@@ -639,7 +639,7 @@
 			status = "disabled";
 		};
 
-		ssp0: ssp at 66180000 {
+		ssp0: spi at 66180000 {
 			compatible = "arm,pl022", "arm,primecell";
 			reg = <0x66180000 0x1000>;
 			interrupts = <GIC_SPI 404 IRQ_TYPE_LEVEL_HIGH>;
@@ -650,7 +650,7 @@
 			status = "disabled";
 		};
 
-		ssp1: ssp at 66190000 {
+		ssp1: spi at 66190000 {
 			compatible = "arm,pl022", "arm,primecell";
 			reg = <0x66190000 0x1000>;
 			interrupts = <GIC_SPI 405 IRQ_TYPE_LEVEL_HIGH>;
arch/arm64/boot/dts/broadcom/stingray/bcm958742-base.dtsi +1 -1
index bc299c3d9068..a9b92e52d50e 100644
@@ -138,7 +138,7 @@
 &i2c1 {
 	status = "okay";
 
-	pcf8574: pcf8574 at 20 {
+	pcf8574: pcf8574 at 27 {
 		compatible = "nxp,pcf8574a";
 		gpio-controller;
 		#gpio-cells = <2>;
arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi +2 -2
index e283480bfc7e..cfeaa855bd05 100644
@@ -521,7 +521,7 @@
 			status = "disabled";
 		};
 
-		ssp0: ssp at 180000 {
+		ssp0: spi at 180000 {
 			compatible = "arm,pl022", "arm,primecell";
 			reg = <0x00180000 0x1000>;
 			interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>;
@@ -533,7 +533,7 @@
 			status = "disabled";
 		};
 
-		ssp1: ssp at 190000 {
+		ssp1: spi at 190000 {
 			compatible = "arm,pl022", "arm,primecell";
 			reg = <0x00190000 0x1000>;
 			interrupts = <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>;
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 arm64: dts: broadcom: Fix I2C and SPI bus warnings

Thanks.

Quoted 8 lines · Rob Herring

dtc has new checks for I2C and SPI buses. Fix the warnings in node names and unit-addresses.

arch/arm64/boot/dts/broadcom/stingray/bcm958742k.dtb: Warning (i2c_bus_reg): /hsls/i2c at e0000/pcf8574 at 20: I2C bus unit address format error, expected "27" arch/arm64/boot/dts/broadcom/stingray/bcm958742t.dtb: Warning (i2c_bus_reg): /hsls/i2c at e0000/pcf8574 at 20: I2C bus unit address format error, expected "27" arch/arm64/boot/dts/broadcom/stingray/bcm958742k.dtb: Warning (spi_bus_bridge): /hsls/ssp at 180000: node name for SPI buses should be 'spi' arch/arm64/boot/dts/broadcom/stingray/bcm958742k.dtb: Warning (spi_bus_bridge): /hsls/ssp at 190000: node name for SPI buses should be 'spi'

Quoted 5 lines
Cc Ray Jui <[email protected]>
Cc Scott Branden <[email protected]>
Cc Jon Mason <[email protected]>
Cc bcm-kernel-feedback-list at broadcom.com
Quoted 66 lines

---
Please apply to the sub-arch tree. The dtc changes haven't landed, but will for 4.20.

  arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi          | 4 ++--
  arch/arm64/boot/dts/broadcom/stingray/bcm958742-base.dtsi | 2 +-
  arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi       | 4 ++--
  3 files changed, 5 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi +2 -2
index 1a406a76c86a..ea854f689fda 100644
@@ -639,7 +639,7 @@
  			status = "disabled";
  		};
 
-		ssp0: ssp at 66180000 {
+		ssp0: spi at 66180000 {
  			compatible = "arm,pl022", "arm,primecell";
  			reg = <0x66180000 0x1000>;
  			interrupts = <GIC_SPI 404 IRQ_TYPE_LEVEL_HIGH>;
@@ -650,7 +650,7 @@
  			status = "disabled";
  		};
 
-		ssp1: ssp at 66190000 {
+		ssp1: spi at 66190000 {
  			compatible = "arm,pl022", "arm,primecell";
  			reg = <0x66190000 0x1000>;
  			interrupts = <GIC_SPI 405 IRQ_TYPE_LEVEL_HIGH>;
arch/arm64/boot/dts/broadcom/stingray/bcm958742-base.dtsi +1 -1
index bc299c3d9068..a9b92e52d50e 100644
@@ -138,7 +138,7 @@
  &i2c1 {
  	status = "okay";
 
-	pcf8574: pcf8574 at 20 {
+	pcf8574: pcf8574 at 27 {
  		compatible = "nxp,pcf8574a";
  		gpio-controller;
  		#gpio-cells = <2>;
arch/arm64/boot/dts/broadcom/stingray/stingray.dtsi +2 -2
index e283480bfc7e..cfeaa855bd05 100644
@@ -521,7 +521,7 @@
  			status = "disabled";
  		};
 
-		ssp0: ssp at 180000 {
+		ssp0: spi at 180000 {
  			compatible = "arm,pl022", "arm,primecell";
  			reg = <0x00180000 0x1000>;
  			interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>;
@@ -533,7 +533,7 @@
  			status = "disabled";
  		};
 
-		ssp1: ssp at 190000 {
+		ssp1: spi at 190000 {
  			compatible = "arm,pl022", "arm,primecell";
  			reg = <0x00190000 0x1000>;
  			interrupts = <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>;
#2 lore raw

PATCH 1/1 arm64: dts: broadcom: Fix I2C and SPI bus warnings

In reply to Rob Herring
Quoted 8 lines · Rob Herring

dtc has new checks for I2C and SPI buses. Fix the warnings in node names and unit-addresses.

arch/arm64/boot/dts/broadcom/stingray/bcm958742k.dtb: Warning (i2c_bus_reg): /hsls/i2c at e0000/pcf8574 at 20: I2C bus unit address format error, expected "27" arch/arm64/boot/dts/broadcom/stingray/bcm958742t.dtb: Warning (i2c_bus_reg): /hsls/i2c at e0000/pcf8574 at 20: I2C bus unit address format error, expected "27" arch/arm64/boot/dts/broadcom/stingray/bcm958742k.dtb: Warning (spi_bus_bridge): /hsls/ssp at 180000: node name for SPI buses should be 'spi' arch/arm64/boot/dts/broadcom/stingray/bcm958742k.dtb: Warning (spi_bus_bridge): /hsls/ssp at 190000: node name for SPI buses should be 'spi'

Quoted 5 lines
Cc Ray Jui <[email protected]>
Cc Scott Branden <[email protected]>
Cc Jon Mason <[email protected]>
Cc bcm-kernel-feedback-list at broadcom.com

Applied to devicetree-arm64/next, thanks Rob!

Signature · 1 line
Florian