Skip to contentSkip to conversation

i2c: synquacer: fix fall-through annotation

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Sep 13, 2018 – Sep 14, 2018

Subsystems (2)
I2C subsystem host drivers Socionext synquacer I2C driver
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 i2c: synquacer: fix fall-through annotation

Replace "fallthru" with a proper "fall through" annotation.

This fix is part of the ongoing efforts to enabling -Wimplicit-fallthrough

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/i2c/busses/i2c-synquacer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-synquacer.c +1 -1
index 915f5ed..2184b7c 100644
@@ -404,7 +404,7 @@ static irqreturn_t synquacer_i2c_isr(int irq, void *dev_id)
 		if (i2c->state == STATE_READ)
 			goto prepare_read;
 
-		/* fallthru */
+		/* fall through */
 
 	case STATE_WRITE:
 		if (bsr & SYNQUACER_I2C_BSR_LRB) {
Signature · 1 line
2.7.4
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Gustavo A. R. Silva

Replace "fallthru" with a proper "fall through" annotation.

This fix is part of the ongoing efforts to enabling -Wimplicit-fallthrough

Signed-off-by Gustavo A. R. Silva <[email protected]>
Acked-by Ard Biesheuvel <[email protected]>
Quoted 20 lines
---
 drivers/i2c/busses/i2c-synquacer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-synquacer.c +1 -2
index 915f5ed..2184b7c 100644
@@ -404,7 +404,7 @@ static irqreturn_t synquacer_i2c_isr(int irq, void *dev_id)
                if (i2c->state == STATE_READ)
                        goto prepare_read;
 
-               /* fallthru */
+               /* fall through */
 
        case STATE_WRITE:
                if (bsr & SYNQUACER_I2C_BSR_LRB) {
--

2.7.4