Skip to contentSkip to conversation

usb: xhci: tegra: Firmware header is little endian

PATCH New Thierry Reding 1 participant 1 message Sep 17, 2018 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 usb: xhci: tegra: Firmware header is little endian

Quoted 8 lines · Greg KH
Quoted 6 lines · Mathias Nyman

From: Thierry Reding <[email protected]>

The XUSB firmware header is in little endian byte order, so make the fields __le32 and __le16 instead of u32 and u16 to avoid warnings from sparse when the fields are used with the endian-aware __le32_to_cpu() and __le16_to_cpu() accessors, respectively.

Quoted 4 lines

This isn't a "bug" in that no code is changed, so why is it needed for 4.19-final?

Shouldn't this be fine to merge in 4.20-rc1?

Yeah, I don't think there's a need to rush this. It's only to fix a warning from sparse, but it shouldn't impact any code since the code itself already properly parses the firmware in little endian byte order.

Thierry