kbuild: Optimize tests and remove shadowed local variable.
PATCH 1/1 kbuild: Optimize tests and remove shadowed local variable.
Removes an unnecessary shadowed local variable (start). Optimize test of isdigit:
- If isalpha returns true, isdigit will return false, so no need to test.
--- scripts/asn1_compiler.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
scripts/asn1_compiler.c +4 -4
@@ -413,7 +413,7 @@ static void tokenise(char *buffer, char *end)/* Handle string tokens */ if (isalpha (*p)) { -const char **dir, *start = p; +const char **dir;/* Can be a directive, type name or element * name. Find the end of the name.
@@ -454,10 +454,10 @@ static void tokenise(char *buffer, char *end) tokens[tix++].token_type =TOKEN_TYPE_NAME ;continue ; - } -/* Handle numbers */ -if (isdigit (*p)) { + }else if (isdigit (*p)) { +/* Handle numbers */ +/* Find the end of the number */ q = p +1 ;while (q < nl && (isdigit (*q)))
Signature · 1 line
2.19.0
FW: David Howells
2018-09-19 8:00 GMT+09:00 Leonardo Brás <[email protected]>:
Quoted 5 lines
Removes an unnecessary shadowed local variable (start). Optimize test of isdigit:
- If isalpha returns true, isdigit will return false, so no need to test.Signed-off-by Leonardo Brás <[email protected]>
This patch was sent to me, but maybe belong to David's field.
David, will you take care of this patch?
https://lore.kernel.org/patchwork/patch/988171/
I think the commit subject should be changed kbuild: -> ASN.1:
Anyway, this patch looks trivial,
FWIW
Quoted 34 lines
--- scripts/asn1_compiler.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)scripts/asn1_compiler.c +4
-5@@ -413,7 +413,7 @@ static void tokenise(char *buffer, char *end)/* Handle string tokens */ if (isalpha (*p)) { -const char **dir, *start = p; +const char **dir;/* Can be a directive, type name or element * name. Find the end of the name. @@ -454,10 +454,10 @@ static void tokenise(char *buffer, char *end) tokens[tix++].token_type =TOKEN_TYPE_NAME ;continue ; - } -/* Handle numbers */ -if (isdigit (*p)) { + }else if (isdigit (*p)) { +/* Handle numbers */ +/* Find the end of the number */ q = p +1 ;while (q < nl && (isdigit (*q))) --2.19.0
Signature · 2 lines
Best Regards Masahiro Yamada
Hello David,
My name is Leonardo and I am new to kernel development.
Is this patch acceptable? Do it need some rework? The change makes sense? Is there a way to better follow the workflow for this patch?
Please let me know if it needs anything.
Best regards,
Leonardo Bras
Quoted 70 lines · Masahiro Yamada
FW: David Howells
2018-09-19 8:00 GMT+09:00 Leonardo Brás <[email protected]>:
Quoted 5 lines
Removes an unnecessary shadowed local variable (start). Optimize test of isdigit:
- If isalpha returns true, isdigit will return false, so no need to test.Signed-off-by Leonardo Brás <[email protected]>This patch was sent to me, but maybe belong to David's field.
David, will you take care of this patch?
https://lore.kernel.org/patchwork/patch/988171/
I think the commit subject should be changed kbuild: -> ASN.1:
Anyway, this patch looks trivial,
FWIWReviewed-by Masahiro Yamada <[email protected]>Quoted 32 lines
--- scripts/asn1_compiler.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)scripts/asn1_compiler.c +4
-5@@ -413,7 +413,7 @@ static void tokenise(char *buffer, char *end)/* Handle string tokens */ if (isalpha (*p)) { -const char **dir, *start = p; +const char **dir;/* Can be a directive, type name or element * name. Find the end of the name. @@ -454,10 +454,10 @@ static void tokenise(char *buffer, char *end) tokens[tix++].token_type =TOKEN_TYPE_NAME ;continue ; - } -/* Handle numbers */ -if (isdigit (*p)) { + }else if (isdigit (*p)) { +/* Handle numbers */ +/* Find the end of the number */ q = p +1 ;while (q < nl && (isdigit (*q))) --Quoted 2 lines
2.19.0
--
Best Regards
Masahiro Yamada
Hi Leonardo, David,
Quoted 9 lines · Leonardo Bras
Hello David,
My name is Leonardo and I am new to kernel development.
Is this patch acceptable? Do it need some rework? The change makes sense? Is there a way to better follow the workflow for this patch?
Please let me know if it needs anything.
I thought David would pick this up,
but he is not responding.
Now, applied to my kbuild tree.
Thanks.
Quoted 77 lines
Best regards,
Leonardo Bras
Quoted 70 lines · Masahiro Yamada
FW: David Howells
2018-09-19 8:00 GMT+09:00 Leonardo Brás <[email protected]>:
Quoted 5 lines
Removes an unnecessary shadowed local variable (start). Optimize test of isdigit:
- If isalpha returns true, isdigit will return false, so no need to test.Signed-off-by Leonardo Brás <[email protected]>This patch was sent to me, but maybe belong to David's field.
David, will you take care of this patch?
https://lore.kernel.org/patchwork/patch/988171/
I think the commit subject should be changed kbuild: -> ASN.1:
Anyway, this patch looks trivial,
FWIWReviewed-by Masahiro Yamada <[email protected]>Quoted 32 lines
--- scripts/asn1_compiler.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)scripts/asn1_compiler.c +4
-5@@ -413,7 +413,7 @@ static void tokenise(char *buffer, char *end)/* Handle string tokens */ if (isalpha (*p)) { -const char **dir, *start = p; +const char **dir;/* Can be a directive, type name or element * name. Find the end of the name. @@ -454,10 +454,10 @@ static void tokenise(char *buffer, char *end) tokens[tix++].token_type =TOKEN_TYPE_NAME ;continue ; - } -/* Handle numbers */ -if (isdigit (*p)) { + }else if (isdigit (*p)) { +/* Handle numbers */ +/* Find the end of the number */ q = p +1 ;while (q < nl && (isdigit (*q))) --Quoted 2 lines
2.19.0
--
Best Regards
Masahiro Yamada
Signature · 2 lines
Best Regards Masahiro Yamada
Thank you!
Please let me know if it needs any rework!
Leonardo Bras
Quoted 108 lines · Masahiro Yamada
Hi Leonardo, David,
Quoted 9 lines · Leonardo Bras
Hello David,
My name is Leonardo and I am new to kernel development.
Is this patch acceptable? Do it need some rework? The change makes sense? Is there a way to better follow the workflow for this patch?
Please let me know if it needs anything.
I thought David would pick this up,
but he is not responding.Now, applied to my kbuild tree.
Thanks.
Quoted 77 lines
Best regards,
Leonardo Bras
Quoted 70 lines · Masahiro Yamada
FW: David Howells
2018-09-19 8:00 GMT+09:00 Leonardo Brás <[email protected]>:
Quoted 5 lines
Removes an unnecessary shadowed local variable (start). Optimize test of isdigit:
- If isalpha returns true, isdigit will return false, so no need to test.Signed-off-by Leonardo Brás <[email protected]>This patch was sent to me, but maybe belong to David's field.
David, will you take care of this patch?
https://lore.kernel.org/patchwork/patch/988171/
I think the commit subject should be changed kbuild: -> ASN.1:
Anyway, this patch looks trivial,
FWIWReviewed-by Masahiro Yamada <[email protected]>Quoted 32 lines
--- scripts/asn1_compiler.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)scripts/asn1_compiler.c +4
-5@@ -413,7 +413,7 @@ static void tokenise(char *buffer, char *end)/* Handle string tokens */ if (isalpha (*p)) { -const char **dir, *start = p; +const char **dir;/* Can be a directive, type name or element * name. Find the end of the name. @@ -454,10 +454,10 @@ static void tokenise(char *buffer, char *end) tokens[tix++].token_type =TOKEN_TYPE_NAME ;continue ; - } -/* Handle numbers */ -if (isdigit (*p)) { + }else if (isdigit (*p)) { +/* Handle numbers */ +/* Find the end of the number */ q = p +1 ;while (q < nl && (isdigit (*q))) --Quoted 2 lines
2.19.0
--
Best Regards
Masahiro Yamada--
Best Regards
Masahiro Yamada