ath10k: Move napi_enable to hif_start for consistent pairing
PATCH 1/2 ath10k: Move napi_enable to hif_start for consistent pairing
There is unbalanced napi_{enable,disable}() behavior as they are being called from hif_snoc_{power_up/stop).
The fix is to call napi_enable() from ath10k_snoc_hif_start() so that it matches with napi_disable() being called from ath10k_snoc_hif_stop().
--- drivers/net/wireless/ath/ath10k/snoc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath10k/snoc.c +1 -1
@@ -919,6 +919,7 @@ static void ath10k_snoc_hif_stop(struct ath10k *ar)static int ath10k_snoc_hif_start (struct ath10k *ar) { +napi_enable (&ar->napi);ath10k_snoc_irq_enable (ar);ath10k_snoc_rx_post (ar);
@@ -1017,7 +1018,6 @@ static int ath10k_snoc_hif_power_up(struct ath10k *ar) goto err_wlan_enable; } -napi_enable (&ar->napi);return 0 ; err_wlan_enable:
Signature · 7 lines
2.18.0 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
PATCH 2/2 ath10k: Disable napi before resource cleanup to avoid "use after free"
CE buffers are cleaned up prior to napi disable and this is causing NULL pointer dereference due to "use after free".
Disable napi before resource cleanup to avoid "use after free".
--- drivers/net/wireless/ath/ath10k/snoc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath10k/snoc.c +1 -1
@@ -911,9 +911,9 @@ static void ath10k_snoc_buffer_cleanup(struct ath10k *ar)static void ath10k_snoc_hif_stop (struct ath10k *ar) {ath10k_snoc_irq_disable (ar); -ath10k_snoc_buffer_cleanup (ar);napi_synchronize (&ar->napi);napi_disable (&ar->napi); +ath10k_snoc_buffer_cleanup (ar);ath10k_dbg (ar,ATH10K_DBG_BOOT ,"boot hif stop\n" ); }
Signature · 7 lines
2.18.0 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 9 lines · Govind Singh
There is unbalanced napi_{enable,disable}() behavior as they are being called from hif_snoc_{power_up/stop).
The fix is to call
napi_enable()fromath10k_snoc_hif_start()so that it matches withnapi_disable()being called fromath10k_snoc_hif_stop().Signed-off-by Govind Singh <[email protected]>Signed-off-by Kalle Valo <[email protected]>
2 patches applied to ath-next branch of ath.git, thanks.
752ed2a229c6 ath10k: move napi_enable to hif_start for consistent pairing 393b9b0f830e ath10k: disable napi before resource cleanup to avoid "use after free"
Signature · 3 lines
https://patchwork.kernel.org/patch/10606859/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 9 lines · Govind Singh
There is unbalanced napi_{enable,disable}() behavior as they are being called from hif_snoc_{power_up/stop).
The fix is to call
napi_enable()fromath10k_snoc_hif_start()so that it matches withnapi_disable()being called fromath10k_snoc_hif_stop().Signed-off-by Govind Singh <[email protected]>Signed-off-by Kalle Valo <[email protected]>
2 patches applied to ath-next branch of ath.git, thanks.
752ed2a229c6 ath10k: move napi_enable to hif_start for consistent pairing 393b9b0f830e ath10k: disable napi before resource cleanup to avoid "use after free"
Signature · 9 lines
https://patchwork.kernel.org/patch/10606859/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k