Skip to contentSkip to conversation

ALSA: xen-front: Refine indentations and constify snd_pcm_ops

PATCH Superseded Nick Simonov 2 participants 7 messages Sep 21, 2018

Subsystems (2)
Sound Xen sound frontend driver
lore
Share & tools
lore

Nick Simonov

author
#0 lore raw

PATCH v2 1/1 ALSA: xen-front: Refine indentations and constify snd_pcm_ops

snd_pcm_ops are not supposed to change. So mark the non-const structs as const. Also, refine indentation to increase readability.

Signed-off-by Nick Simonov <[email protected]>

---
Changes v2:
- Fix typo in commit description, ncrease to increase.

 sound/xen/xen_snd_front_alsa.c | 46 +++++++++++++++++++++---------------------
 1 file changed, 23 insertions(+), 23 deletions(-)
sound/xen/xen_snd_front_alsa.c +23 -23
index 129180e..2cbd967 100644
@@ -637,31 +637,31 @@ static int alsa_pb_fill_silence(struct snd_pcm_substream *substream,
  * to know when the buffer can be transferred to the backend.
  */
 
-static struct snd_pcm_ops snd_drv_alsa_playback_ops = {
-	.open = alsa_open,
-	.close = alsa_close,
-	.ioctl = snd_pcm_lib_ioctl,
-	.hw_params = alsa_hw_params,
-	.hw_free = alsa_hw_free,
-	.prepare = alsa_prepare,
-	.trigger = alsa_trigger,
-	.pointer = alsa_pointer,
-	.copy_user = alsa_pb_copy_user,
-	.copy_kernel = alsa_pb_copy_kernel,
-	.fill_silence = alsa_pb_fill_silence,
+static const struct snd_pcm_ops snd_drv_alsa_playback_ops = {
+	.open		= alsa_open,
+	.close		= alsa_close,
+	.ioctl		= snd_pcm_lib_ioctl,
+	.hw_params	= alsa_hw_params,
+	.hw_free	= alsa_hw_free,
+	.prepare	= alsa_prepare,
+	.trigger	= alsa_trigger,
+	.pointer	= alsa_pointer,
+	.copy_user	= alsa_pb_copy_user,
+	.copy_kernel	= alsa_pb_copy_kernel,
+	.fill_silence	= alsa_pb_fill_silence,
 };
 
-static struct snd_pcm_ops snd_drv_alsa_capture_ops = {
-	.open = alsa_open,
-	.close = alsa_close,
-	.ioctl = snd_pcm_lib_ioctl,
-	.hw_params = alsa_hw_params,
-	.hw_free = alsa_hw_free,
-	.prepare = alsa_prepare,
-	.trigger = alsa_trigger,
-	.pointer = alsa_pointer,
-	.copy_user = alsa_cap_copy_user,
-	.copy_kernel = alsa_cap_copy_kernel,
+static const struct snd_pcm_ops snd_drv_alsa_capture_ops = {
+	.open		= alsa_open,
+	.close		= alsa_close,
+	.ioctl		= snd_pcm_lib_ioctl,
+	.hw_params	= alsa_hw_params,
+	.hw_free	= alsa_hw_free,
+	.prepare	= alsa_prepare,
+	.trigger	= alsa_trigger,
+	.pointer	= alsa_pointer,
+	.copy_user	= alsa_cap_copy_user,
+	.copy_kernel	= alsa_cap_copy_kernel,
 };
 
 static int new_pcm_instance(struct xen_snd_front_card_info *card_info,
Signature · 1 line
2.7.4
#1 lore raw

PATCH v2 1/1 ALSA: xen-front: Refine indentations and constify snd_pcm_ops

Quoted 9 lines · Nick Simonov

snd_pcm_ops are not supposed to change. So mark the non-const structs as const. Also, refine indentation to increase readability.

Signed-off-by Nick Simonov <[email protected]>

---
Changes v2:
- Fix typo in commit description, ncrease to increase.

Since I already merged your first version, please resubmit as an incremental patch. At best, check the latest linux-next or my sound.git tree for-next branch, and create a patch on its top.

thanks,

Takashi

author
#2 lore raw
Quoted 12 lines · Takashi Iwai
Quoted 9 lines · Nick Simonov

snd_pcm_ops are not supposed to change. So mark the non-const structs as const. Also, refine indentation to increase readability.

Signed-off-by Nick Simonov <[email protected]>

---
Changes v2:
- Fix typo in commit description, ncrease to increase.

Quoted 8 lines

Since I already merged your first version, please resubmit as an incremental patch. At best, check the latest linux-next or my sound.git tree for-next branch, and create a patch on its top.

thanks,

Takashi

Sorry I want to clarify, there is no mistakes in the code itself there is a typo in commit message. As I now there is no way to change commit message without rebase after merge, so which is the proper way in this case? leave it as is?

Thanks,

Nick

#3 lore raw
Quoted 19 lines · Nick Simonov
Quoted 17 lines · Takashi Iwai
Quoted 9 lines · Nick Simonov

snd_pcm_ops are not supposed to change. So mark the non-const structs as const. Also, refine indentation to increase readability.

Signed-off-by Nick Simonov <[email protected]>

---
Changes v2:
- Fix typo in commit description, ncrease to increase.

Since I already merged your first version, please resubmit as an incremental patch. At best, check the latest linux-next or my sound.git tree for-next branch, and create a patch on its top.

Quoted 8 lines
Quoted 3 lines

thanks,

Takashi

Sorry I want to clarify, there is no mistakes in the code itself there is a typo in commit message. As I now there is no way to change commit message without rebase after merge, so which is the proper way in this case? leave it as is?

Then let's leave as is.

thanks,

Takashi

#4 lore raw
In reply to Nick Simonov
Quoted 19 lines · Nick Simonov
Quoted 17 lines · Takashi Iwai
Quoted 9 lines · Nick Simonov

snd_pcm_ops are not supposed to change. So mark the non-const structs as const. Also, refine indentation to increase readability.

Signed-off-by Nick Simonov <[email protected]>

---
Changes v2:
- Fix typo in commit description, ncrease to increase.

Since I already merged your first version, please resubmit as an incremental patch. At best, check the latest linux-next or my sound.git tree for-next branch, and create a patch on its top.

Quoted 8 lines
Quoted 3 lines

thanks,

Takashi

Sorry I want to clarify, there is no mistakes in the code itself there is a typo in commit message. As I now there is no way to change commit message without rebase after merge, so which is the proper way in this case? leave it as is?

Then let's leave as is.

thanks,

Takashi

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

author
#5 lore raw
In reply to Takashi Iwai
Quoted 12 lines · Takashi Iwai
Quoted 9 lines · Nick Simonov

snd_pcm_ops are not supposed to change. So mark the non-const structs as const. Also, refine indentation to increase readability.

Signed-off-by Nick Simonov <[email protected]>

---
Changes v2:
- Fix typo in commit description, ncrease to increase.

Quoted 8 lines

Since I already merged your first version, please resubmit as an incremental patch. At best, check the latest linux-next or my sound.git tree for-next branch, and create a patch on its top.

thanks,

Takashi

Sorry I want to clarify, there is no mistakes in the code itself there is a typo in commit message. As I now there is no way to change commit message without rebase after merge, so which is the proper way in this case? leave it as is?

Thanks,

Nick

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#6 lore raw

PATCH v2 1/1 ALSA: xen-front: Refine indentations and constify snd_pcm_ops

In reply to Nick Simonov
Quoted 9 lines · Nick Simonov

snd_pcm_ops are not supposed to change. So mark the non-const structs as const. Also, refine indentation to increase readability.

Signed-off-by Nick Simonov <[email protected]>

---
Changes v2:
- Fix typo in commit description, ncrease to increase.

Since I already merged your first version, please resubmit as an incremental patch. At best, check the latest linux-next or my sound.git tree for-next branch, and create a patch on its top.

thanks,

Takashi

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel