devlink: double free in devlink_resource_fill()
Subsystems (3)
PATCH 1/1 devlink: double free in devlink_resource_fill()
Smatch reports that devlink_dpipe_send_and_alloc_skb() frees the skb on error so this is a double free. We fixed a bunch of these bugs in commit 7fe4d6dcbcb4 ("devlink: Remove redundant free on error path") but we accidentally overlooked this one.
Fixes d9f9b9a4d05f ("devlink: Add support for resource abstraction")
Signed-off-by Dan Carpenter <[email protected]>
net/core/devlink.c +1 -2
@@ -2592,7 +2592,7 @@ static int devlink_resource_fill(struct genl_info *info,if (!nlh) { err =devlink_dpipe_send_and_alloc_skb (&skb, info);if (err) - goto err_skb_send_alloc; +return err; goto send_done; }return genlmsg_reply (skb, info);
@@ -2600,7 +2600,6 @@ static int devlink_resource_fill(struct genl_info *info, nla_put_failure: err = -EMSGSIZE ; err_resource_put: -err_skb_send_alloc:nlmsg_free (skb);return err; }
Quoted 7 lines · Fri, Sep 21, 2018 at 10:07:55AM CEST, [email protected] wrote:
Smatch reports that
devlink_dpipe_send_and_alloc_skb()frees the skb on error so this is a double free. We fixed a bunch of these bugs in commit7fe4d6dcbcb4("devlink: Remove redundant free on error path") but we accidentally overlooked this one.Fixes d9f9b9a4d05f ("devlink: Add support for resource abstraction")Signed-off-by Dan Carpenter <[email protected]>
Acked-by Jiri Pirko <[email protected]>